From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#68570: 29.1; recompile might not re-use project-compile's buffer Date: Fri, 26 Jan 2024 02:44:17 +0200 Message-ID: <2a3f08b8-5334-41c6-8003-707424a8a0fe@gutov.dev> References: <920b0c20-c6ee-4b41-84ec-5adfa06c64a2@jbornemann.de> <320b09d1-2af4-4110-bdf3-94da122f3dd6@gutov.dev> <86il3m1zi7.fsf@mail.linkov.net> <60842df3-8a64-4bde-b6d6-f94b9a964a17@gutov.dev> <86fryp7ubp.fsf@mail.linkov.net> <871a3ea4-46d9-419e-a375-1d32968ccc88@jbornemann.de> <867ck0leif.fsf@mail.linkov.net> <0598898e-8e25-43b1-92c0-4596ad242ec8@gutov.dev> <86bk9b6vu4.fsf@mail.linkov.net> <86o7da1ws8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: =?UTF-8?Q?J=C3=B6rg?= Bornemann , 68570@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 26 01:45:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTALP-0004Pb-Ka for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Jan 2024 01:45:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTAL4-00025U-Ei; Thu, 25 Jan 2024 19:44:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTAL2-000255-Bu for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 19:44:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTAL2-0001vV-2U for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 19:44:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTAL7-0001f9-VJ for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2024 19:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 00:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68570 X-GNU-PR-Package: emacs Original-Received: via spool by 68570-submit@debbugs.gnu.org id=B68570.17062298766338 (code B ref 68570); Fri, 26 Jan 2024 00:45:01 +0000 Original-Received: (at 68570) by debbugs.gnu.org; 26 Jan 2024 00:44:36 +0000 Original-Received: from localhost ([127.0.0.1]:49652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTAKi-0001eA-FW for submit@debbugs.gnu.org; Thu, 25 Jan 2024 19:44:36 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTAKf-0001ds-F9 for 68570@debbugs.gnu.org; Thu, 25 Jan 2024 19:44:34 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 8FE345C00A6; Thu, 25 Jan 2024 19:44:21 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 25 Jan 2024 19:44:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1706229861; x=1706316261; bh=aZeNG+5TanN5UOCW5NpyDcuaDohyXmZ16tVHd0kVnTA=; b= gWBEh5T4Ksh9W72TAbRhUg0qCEXmUQeaqtrXNfUcrBMzR3dyTpeG3srwhZxuQMoE 1XOaX7dIrU0hK71zU574BPBIp+W4TPr0/U/bEBNiPkaR/Y5AbqX7Wr2xV1cqGdZ1 9rg96V4X16UVc3p7HzpmWBVzF+bEJXeSAYOnC0z290x7Drj0tnY9X/BwuCKMmLQV R4Y1KK5FWrYS3bXAwGgZitEyvOb+eIyQgidjGjIrAo8igTuZggtUzjrNBtyAdgxq 3e6a4oW3R7ZGu4NIGry3SBL8lptjXT+SOWKB+p/9JG7DQEFRtemMcfltrippZUyw 7mlx6qQy2R0xnqoR0GthpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706229861; x= 1706316261; bh=aZeNG+5TanN5UOCW5NpyDcuaDohyXmZ16tVHd0kVnTA=; b=l BJFraQruzFSZQL0NKuEph24CaYBlEir0N1aMvPL6T9v7gjro0CU6e5xM0gjt+vL9 g+mIqgePIzffcCWW/JcpSFGbWIIXDiQafmiQ+NgrUqoiNlKVRi2NsRkCbqa2+aMR OYedcTkPhoKt+N33ELUaxh/9vAzAKSZ6r94WwX6U59CDWZYKHQ2zgmNNpLlAApkt 7kWcDBfwypJVMOU56bU1vnGBJf5EwZCf57Ifbnc72rOw4AbER/2E8LlcEtufUqaf DWUj9CbvLMBC3DMomhJV6Z2ud8X2FmWi2ihTCqVYZRpaa+tPI6ZIUka7Ai+f5oXI ao/ABaaqBdu1NuFS/+YTw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeliedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 Jan 2024 19:44:20 -0500 (EST) Content-Language: en-US In-Reply-To: <86o7da1ws8.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278880 Archived-At: On 24/01/2024 19:11, Juri Linkov wrote: >>>>> Recompiling from a non-compilation buffer has security concerns. >>>>> The patch that I proposed above is intended only for >>>>> recompiling from a compilation buffer. It sets >>>>> `compilation-buffer-name-function' in the compilation buffer. >>>> I think it behaves correctly inside the compilation buffer already? At >>>> least it did when I tested. >>> Sorry, I didn't show my compilation function: >>> (setopt project-compilation-buffer-name-function >>> (lambda (name-of-mode) >>> (generate-new-buffer-name >>> (project-prefixed-buffer-name name-of-mode)))) >>> Currently 'g' doesn't create a new compilation buffer, because >>> 'compilation--default-buffer-name' just reuses the current buffer. >> >> Is that bad? > > It's very useful to always create a unique buffer for every compilation: > this allows keeping error messages from previous compilations. Hmm, but I suppose it can be a personal preference whether a "recompile" should create a new buffer or not. Because it's also reasonable to expect that 'M-x compile' creates a new buffer (e.g. project-prefixed and unique), but 'recompile', or 'revert-buffer' - keep that buffer around and reuse it. When one wants to keep the old contents, they could 'M-x compile' (or 'M-x project-compile') instead. This might be my preference anyway, because OT1H old compilations are often (but not always) handy to have around, OT2H I don't like to have too many buffers, and the above distinction between 'compile' and 'recompile' would be a tool to make that choice. > I propose even to add such an option to the choice list in > project-compilation-buffer-name-function, e.g.: > > (defcustom project-compilation-buffer-name-function nil > :type '(choice (const :tag "Default" nil) > (const :tag "Prefixed with project name" > project-prefixed-buffer-name) > (const :tag "Prefixed and unique with project name" > project-prefixed-unique-buffer-name) > (function :tag "Custom function"))) Sounds good. > The previous patch would be needed as well since currently > there is no way to allow unique project compilation buffers. The one in 0a07603ae8d?