From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2 00/15] xwidget webkit improvements Date: Tue, 25 Oct 2016 08:30:50 -0700 Organization: UCLA Computer Science Department Message-ID: <2a39f450-c1ae-3fce-8aa4-d12d2e7506ec@cs.ucla.edu> References: <20161024164101.26043-1-rekado@elephly.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1477409491 11865 195.159.176.226 (25 Oct 2016 15:31:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Oct 2016 15:31:31 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 To: Ricardo Wurmus , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 25 17:31:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz3h1-0000bU-1S for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2016 17:31:11 +0200 Original-Received: from localhost ([::1]:55698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz3h3-0000QL-E2 for ged-emacs-devel@m.gmane.org; Tue, 25 Oct 2016 11:31:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bz3gs-0000OP-RD for emacs-devel@gnu.org; Tue, 25 Oct 2016 11:31:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bz3gp-00044g-Io for emacs-devel@gnu.org; Tue, 25 Oct 2016 11:31:02 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34937) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bz3gp-000445-Cv for emacs-devel@gnu.org; Tue, 25 Oct 2016 11:30:59 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4F4EF161064; Tue, 25 Oct 2016 08:30:57 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 67-Bj5eLUxdM; Tue, 25 Oct 2016 08:30:53 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 90096161062; Tue, 25 Oct 2016 08:30:53 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VjidxYaQHr_W; Tue, 25 Oct 2016 08:30:53 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 79DFC160F97; Tue, 25 Oct 2016 08:30:53 -0700 (PDT) In-Reply-To: <20161024164101.26043-1-rekado@elephly.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208774 Archived-At: Thanks. I tried that on Fedora 24 x86-64, and got the following diagnostic when using M-x xwidget-webkit-browse-url to visit http://cs.ucla.edu. (emacs:22840): Gtk-WARNING **: Allocating size to GtkOffscreenWindow 0xd5b6d0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? Is this something I should worry about? A couple of minor things. First, in patch "Dynamically resize WebKit widget", this commit-message line exceeds 78 chars: (xwidget-webkit-adjust-size-to-window): Make non-interactive, add widget and window as arguments. so "git am" rejected it here. To help prevent this sort of problem in the future, run "./autogen.sh git". (72 chars or less is nice, so that ChangeLog lines fit in 80 columns.) Second, in the patch "xwidget: Pass JavaScript return value to optional callback procedure" the new function webkit_js_to_lisp should be static. To catch this sort of thing in the future, use the --enable-gcc-warnings option to 'configure'.