From: Paul Eggert <eggert@cs.ucla.edu>
To: Ricardo Wurmus <rekado@elephly.net>, emacs-devel@gnu.org
Subject: Re: [PATCH v2 00/15] xwidget webkit improvements
Date: Tue, 25 Oct 2016 08:30:50 -0700 [thread overview]
Message-ID: <2a39f450-c1ae-3fce-8aa4-d12d2e7506ec@cs.ucla.edu> (raw)
In-Reply-To: <20161024164101.26043-1-rekado@elephly.net>
Thanks. I tried that on Fedora 24 x86-64, and got the following
diagnostic when using M-x xwidget-webkit-browse-url to visit
http://cs.ucla.edu.
(emacs:22840): Gtk-WARNING **: Allocating size to GtkOffscreenWindow
0xd5b6d0 without calling gtk_widget_get_preferred_width/height(). How
does the code know the size to allocate?
Is this something I should worry about?
A couple of minor things. First, in patch "Dynamically resize WebKit
widget", this commit-message line exceeds 78 chars:
(xwidget-webkit-adjust-size-to-window): Make non-interactive, add widget and window as arguments.
so "git am" rejected it here. To help prevent this sort of problem in
the future, run "./autogen.sh git". (72 chars or less is nice, so that
ChangeLog lines fit in 80 columns.)
Second, in the patch "xwidget: Pass JavaScript return value to optional
callback procedure" the new function webkit_js_to_lisp should be static.
To catch this sort of thing in the future, use the --enable-gcc-warnings
option to 'configure'.
next prev parent reply other threads:[~2016-10-25 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:40 [PATCH v2 00/15] xwidget webkit improvements Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 01/15] xwidget: Use WebKit2 API Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 02/15] xwidget: Pass JavaScript return value to optional callback procedure Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 03/15] Remove scrolled window container around WebKit widget Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 04/15] xwidget: Do not use `xwidget-execute-script-rv' to insert string Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 05/15] xwidget: Get title via asynchronous JavaScript Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 06/15] xwidget: Simplify functions to scroll to elements Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 07/15] xwidget: Add function to find element by CSS selector Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 08/15] xwidget: Get selection with asynchronous JavaScript Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 09/15] xwidget: Get URL asynchronously Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 10/15] xwidget: Remove title hack Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 11/15] Let initial WebKit view fill window Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 12/15] Dynamically resize WebKit widget Ricardo Wurmus
2016-10-24 16:40 ` [PATCH 13/15] Implement zoom for " Ricardo Wurmus
2016-10-24 16:41 ` [PATCH 14/15] xwidget: Bind "beginning-of-buffer" and "end-of-buffer" Ricardo Wurmus
2016-10-24 16:41 ` [PATCH 15/15] xwidget: Map "previous-line" and "next-line" to scroll Ricardo Wurmus
2016-10-25 15:30 ` Paul Eggert [this message]
2016-10-26 5:12 ` [PATCH v2 00/15] xwidget webkit improvements Ricardo Wurmus
2016-10-26 6:08 ` Paul Eggert
2016-10-26 9:18 ` joakim
2016-10-26 9:19 ` joakim
2016-10-26 8:08 ` Live System User
2016-10-26 8:14 ` Live System User
-- strict thread matches above, loose matches on Subject: below --
2016-10-24 16:39 Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a39f450-c1ae-3fce-8aa4-d12d2e7506ec@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.