From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.emacs.bugs Subject: bug#61577: 30.0.50; project-try-vc missing vc-got Date: Fri, 17 Feb 2023 17:56:19 +0100 Message-ID: <2MYESNXYSQ3GQ.3N8R7R6RHZZ02@venera> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mblaze/1.2 To: 61577@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 17 17:57:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT42w-000AED-6n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Feb 2023 17:57:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pT42i-0002lo-CM; Fri, 17 Feb 2023 11:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT42g-0002ku-UU for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pT42g-0006DT-L9 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pT42g-0007nX-7V for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Omar Polo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61577 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167665299529933 (code B ref -1); Fri, 17 Feb 2023 16:57:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Feb 2023 16:56:35 +0000 Original-Received: from localhost ([127.0.0.1]:41319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42E-0007mi-P7 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:35 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT42D-0007ma-3m for submit@debbugs.gnu.org; Fri, 17 Feb 2023 11:56:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT42A-0002ay-WC for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:31 -0500 Original-Received: from mail.omarpolo.com ([144.91.116.244]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT427-0005f0-22 for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 11:56:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1676652980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=He5uQTNL53KrbY3bBOQEjew5Zl7MuHKwD8AMbwaGN94=; b=oXk2KQbfO6iCAY+GASxlKKfC0CeBvNQnSpyWcgKcDeZlge1WahamTl9ZfUdYUFeqKI/RYL nFYDYe4HY/JNfZF+4NM+8jaIU+rFHi4WBoByK7pRRh1pXdNf+ukGj6AS1YtoEZEzsAINLb WW806SqJnXrkZ652dahv1zWkCP57FF0= Original-Received: from localhost (host-87-2-235-1.retail.telecomitalia.it [87.2.235.1]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 947d7053 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 17 Feb 2023 17:56:20 +0100 (CET) Original-Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id d790ff27 for ; Fri, 17 Feb 2023 17:56:19 +0100 (CET) Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255891 Archived-At: Hello, project-try-vc (IIRC) used to loop over all the vc-backends to find the root of a project. Now, it=E2=80=99s just an hardcoded list in a local variable. This breaks the project-* functions on Got checkouts. I can imagine the reason of the change (avoid loading all the vc-*.el files I guess) but it would be nice for this variable to be at least user-configurable, otherwise we will always end up with missing entries. (Yeah, one could add their own hooks in project-find-functions for that, but seems replicating stuff that project.el tries to do anyway.) Attaching a diff that temporarly works around the problem by adding the Got -> .got mapping. Thanks, Omar Polo diff /home/op/build/emacs commit - dabd7feb950ef2dba0ce23ec74c5b141cff96a55 path + /home/op/build/emacs blob - 2343adf4698471cf5262ce7a4340a4b0c5b5fa7e file + lisp/progmodes/project.el --- lisp/progmodes/project.el +++ lisp/progmodes/project.el @@ -506,7 +506,8 @@ project backend implementation of `project-external-ro (Bzr . ".bzr") (SVN . ,vc-svn-admin-directory) (DARCS . "_darcs") - (Fossil . ".fslckout"))) + (Fossil . ".fslckout") + (Got . ".got"))) (backend-markers (delete nil In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, X toolkit, cairo version 1.17.8, Xaw scroll bars) of 2023-02-16 built on venera Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD venera 7.2 GENERIC.MP#1052 amd64 Configured using: 'configure --prefix /home/op/opt/emacs --with-x-toolkit=3Dlucid' Configured features: CAIRO DBUS FREETYPE GIF GLIB GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY KQUEUE PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: shell-dirtrack-mode: t eshell-prompt-mode: t eshell-pred-mode: t eshell-hist-mode: t eshell-cmpl-mode: t eshell-proc-mode: t eshell-arg-mode: t server-mode: t shackle-mode: t global-form-feed-mode: t electric-pair-mode: t savehist-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-quote-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t abbrev-mode: t Load-path shadows: ~/build/emacs-libpq/pq hides /home/op/.emacs.d/elpa/pq-0.1/pq /home/op/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/op/opt/emacs/s= hare/emacs/30.0.50/lisp/progmodes/eglot Features: (shadow sort mail-extr emacsbug bug-reference noutline outline reposition em-unix yaml-mode debug backtrace pcmpl-unix pcmpl-gnu warnings em-term term disp-table shell ehelp em-script em-prompt em-pred em-ls em-hist em-glob em-extpipe em-cmpl em-dirs em-basic em-banner em-alias esh-mode esh-var pcomplete eshell esh-cmd generator esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cus-edit cus-start cus-load wid-edit diff-mode ispell term/xterm xterm files-x find-dired vc-got log-view compile vc-dir ewoc log-edit message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log vc-annotate vc vc-dispatcher mule-util display-line-numbers icons xref vc-svn cl-print ielm pp comint ansi-osc ansi-color ring dired-aux dired-x dired dired-loaddefs puni pulse color imenu misearch multi-isearch jka-compr find-func shortdoc text-property-search cl-extra rx orderless project help-fns radix-tree server shackle trace checkdoc lisp-mnt thingatpt help-mode form-feed elec-pair savehist saveplace whitespace orderless-autoloads fennel-mode-autoloads geiser-guile-autoloads geiser-autoloads finder-inf gemini-mode-autoloads go-mode-autoloads haskell-mode-autoloads lua-mode-autoloads markdown-mode-autoloads puni-autoloads easy-mmode info sly-autoloads eglot-autoloads pq-autoloads web-mode-autoloads yaml-mode-autoloads cider-autoloads sesman-autoloads spinner-autoloads queue-autoloads parseedn-autoloads parseclj-autoloads clojure-mode-autoloads vc-got-autoloads vc-fossil-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib minimal-theme rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 386600 40031) (symbols 48 21832 1) (strings 32 116838 2419) (string-bytes 1 3104440) (vectors 16 41495) (vector-slots 8 615081 20384) (floats 8 287 891) (intervals 56 5909 2186) (buffers 976 34))