From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Tue, 06 Aug 2019 21:25:00 +0200 Message-ID: <2F586079-3687-4DF0-984D-467F442E68D1@aol.com> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> <83zhksexvx.fsf@gnu.org> <87sgqhricg.fsf@mail.linkov.net> <87o914u65x.fsf@mail.linkov.net> <04C790C7-2667-4480-BDC9-BE838D307A74@aol.com> <837e7qcpbj.fsf@gnu.org> <20190806175146.fpgzslvlaydpih7k@Ergus> <831rxycfqp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="43904"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android Cc: 36861@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 06 21:26:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hv560-000BH7-QF for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Aug 2019 21:26:08 +0200 Original-Received: from localhost ([::1]:35900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hv55z-0002ml-L9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Aug 2019 15:26:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52211) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hv55v-0002mc-92 for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 15:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hv55u-0007KM-0c for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 15:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hv55t-0007K3-T8 for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 15:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hv55t-0003rG-Lw for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2019 15:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Aug 2019 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156511951614771 (code B ref 36861); Tue, 06 Aug 2019 19:26:01 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 6 Aug 2019 19:25:16 +0000 Original-Received: from localhost ([127.0.0.1]:37799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv559-0003qA-Tp for submit@debbugs.gnu.org; Tue, 06 Aug 2019 15:25:16 -0400 Original-Received: from sonic309-25.consmr.mail.ir2.yahoo.com ([77.238.179.83]:45075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hv557-0003pt-QR for 36861@debbugs.gnu.org; Tue, 06 Aug 2019 15:25:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565119507; bh=uOKowXAXBrkY7c7qVNuDoXCPCnPkjo3gbfDxest1DNo=; h=Date:In-Reply-To:References:Subject:To:From:From:Subject; b=H6qbXK60zomdTBVSpiwyKrUD9jtq967bG2KTbk7S3l+xeoL3UJRTOuNJfaFguZ8y+DBqxu2jFeU4+vrc4fRpKrixUyaYRYX9ZQ8gnCkKA+Yi6aFQtTDed6epDwxBQt6PRrqtxsAr46duXqsYadq1vwlMwsl905T6YifqVdR0FS6j/ke2JXlF8n1cph5lJyD/mmgT4+81QietDZ4FOm6XtWav5nS4A5HwnYuVGxlIko3q77SXD7ZcwUs3pGlrLCJ/lO4Q3gxvXgQqbRdq/p20Ov+uH+7wNpBs5hUFfo+U5OpgLoLKp4YcWnSXG3LkU8mDv8DPmlbfwJtHMFlb4yZHdQ== X-YMail-OSG: hIAttnsVM1kcQdZml_4ZyfLCw2W3NPRLB5oRIJ6SIhPaEgiB9q_bfeKEY3wokzU 3SLvNRv_MOSjq6IuqeEYmb8wFigFqUYn8bwIV5adDLmcTlxSZRRtXyf1ttjBQlxy9IXdTgqSAz1_ gydbTYIz1u1rY5Qjz_k30FO5YkADXII8OshaQ7tuE_v3USQw.upaWJEUPv1eW_gT.xs3B1zL_5cp QopKTHEUic2fcJr649CpGMrGEf6sauFmuSiJ2tMnQe_lRaMAmJsN5GFTJld944JdyAtHvZXK5U35 XS10DRtRu0OzZppniKTWCZIU_UOt9BDBuCBzZLB4UkFbsZTYxEjMyhc5PJPwD6mUz539AuEzt4K4 RiyPMhkZVbrrhq7S6pG4WMPGSOdFJsXShL5YqyOwi2F7rWiIoHIDkhvWRqlO.TxoiGibNnzRgdRE kmFaat54WGZlNY7EWUgQxQOAxGAhIp6YdowJUT1UvqcrBbzc7aLnLPX2HOnpik80_U7Fn93v3Y77 gTO4MuYcTI.Huky7e.K6nTJvx9LvnGbzgYq8n5ImMvyfUTmnEMkj0Em1LT.8flpaAiImQkoMqLsd GF6wd7tMe3RAEmbP0iSFI56IWC8kmKI_y_4hLT85IVzZyWjdYNVUn.OVJIWK5tkBn50GA7iHX8XG 9RA7QYt61y..Eps3ibtuMuivissfmOjLGlFIak8eG9JCRQBhW2GRvjxZZDj.YT8TfFxL_OBB7ahw jw8ULogExI74.mbhGRcwU3m0f4dn1o1dprE5RH1SknqMYPwKF7F42wWFIOLc7l2o87PYKZF366kE _6VtriXplpyf8Vw7HCCyId2Iu2Qt3X.AMzjGCQVbs. Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Tue, 6 Aug 2019 19:25:07 +0000 Original-Received: by smtp420.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b769fb70379b4d09306779308fb4124c; Tue, 06 Aug 2019 19:25:03 +0000 (UTC) In-Reply-To: <831rxycfqp.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164692 Archived-At: ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable We can do that=2E=2E=2E I was just trying to avoid using ?| by default in a= ny case=2E=20 There is also the case when a user sets ?| by default and then call the fu= nction=2E If the check we add is just comparing to the default value then ?= | will be always overwritten so an extra internal variable will be needed t= o cache where the ?| comes from=2E But OK, if this use case seems to be gen= eral enough I can make this changes=2E BTW=2E Have you seen my comments abo= ut the display engine in the other issue? Best, Ergus On August 6, 2019 8:26:22 PM GMT+02:00, Eli Zaretskii wro= te: >> Date: Tue, 6 Aug 2019 19:51:46 +0200 >> From: Ergus >> Cc: juri@linkov=2Enet, 36861@debbugs=2Egnu=2Eorg >>=20 >> >I don't think I understand the problem=2E Why doesn't just setting >the >> >characters and the mode variable work as expected? AFAIU, one needs >> >to call the mode function only if one wants Emacs to deduce the >> >indicator character automatically=2E >>=20 >> Hi: >>=20 >> It should work as you say=2E But the default value for >> display-fill-column-indicator-character is nil until the mode >function >> is executed (at least once)=2E >>=20 >> I think that what they want is >display-fill-column-indicator-character >> to be non-nil without initialization; which we cannot set without >some >> checks=2E > >Why can't we set display-fill-column-indicator-character to ?| by >default? Invoking the mode function will still do its job, but at >least people who want to just set the variable will have a functional >feature=2E Am I missing something? --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable We can do that=2E=2E=2E I was just trying to avoid= using ?| by default in any case=2E

There is also the case when a u= ser sets ?| by default and then call the function=2E If the check we add is= just comparing to the default value then ?| will be always overwritten so = an extra internal variable will be needed to cache where the ?| comes from= =2E But OK, if this use case seems to be general enough I can make this cha= nges=2E BTW=2E Have you seen my comments about the display engine in the ot= her issue?
Best,
Ergus



On A= ugust 6, 2019 8:26:22 PM GMT+02:00, Eli Zaretskii <eliz@gnu=2Eorg> wr= ote:
Dat=
e: Tue, 6 Aug 2019 19:51:46 +0200
From: Ergus <spacibba@aol=2Ecom>=

Cc: juri@linkov=2Enet, 36861@debbugs=2Egnu=2Eorg

I don't think I understand the problem=2E=
  Why doesn't just setting the
characters and the mode variable work as =
expected?  AFAIU, one needs
to call the mode function only if one wants =
Emacs to deduce the
indicator character automatically=2E

Hi:

It should work as you say=2E But the default value for
d=
isplay-fill-column-indicator-character is nil until the mode function
is=
 executed (at least once)=2E

I think that what they want is display-=
fill-column-indicator-character
to be non-nil without initialization; wh=
ich we cannot set without some
checks=2E

Why can't w=
e set display-fill-column-indicator-character to ?| by
default?  Invokin=
g the mode function will still do its job, but at
least people who want =
to just set the variable will have a functional
feature=2E  Am I missing=
 something?

--
Sent from my Android dev= ice with K-9 Mail=2E Please excuse my brevity=2E ------0M3XFHE5MIYAOWEJQOZPMIB6ULP6Q9--