From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Andrus Newsgroups: gmane.emacs.bugs Subject: bug#23679: 25.0.94; vc-region-history does not work correctly when narrowed Date: Wed, 1 Jun 2016 20:44:03 -0600 Message-ID: <2DC550A0-0BEB-4BEB-88BD-F8C0F1606069@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1464835526 6317 80.91.229.3 (2 Jun 2016 02:45:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Jun 2016 02:45:26 +0000 (UTC) To: 23679@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 02 04:45:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b8IdG-0005Kn-1I for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Jun 2016 04:45:14 +0200 Original-Received: from localhost ([::1]:44919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8IdE-00048l-TB for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Jun 2016 22:45:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Id9-000467-FN for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:45:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8Id4-0005mB-6t for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Id4-0005m7-2x for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b8Id3-0000XO-UE for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Andrus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jun 2016 02:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23679 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14648354621998 (code B ref -1); Thu, 02 Jun 2016 02:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jun 2016 02:44:22 +0000 Original-Received: from localhost ([127.0.0.1]:50346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8IcP-0000WA-Rj for submit@debbugs.gnu.org; Wed, 01 Jun 2016 22:44:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8IcO-0000Vw-Ht for submit@debbugs.gnu.org; Wed, 01 Jun 2016 22:44:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8IcI-0005Zq-LE for submit@debbugs.gnu.org; Wed, 01 Jun 2016 22:44:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8IcI-0005ZV-Hs for submit@debbugs.gnu.org; Wed, 01 Jun 2016 22:44:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8IcG-000440-Af for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:44:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8IcB-0005Yk-8u for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:44:11 -0400 Original-Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]:36049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8IcB-0005Yg-3b for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2016 22:44:07 -0400 Original-Received: by mail-io0-x22a.google.com with SMTP id k19so21313242ioi.3 for ; Wed, 01 Jun 2016 19:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=VNle0uB1CHJfrgZZMNmGpGpI9dCcYAP5Bi4Y4IEYdBA=; b=fxzFp/2eDojV4ElvZ4XxzxUmN18pRAP7C+fzYfNMxODUzT1C2be5Q274mAJNtybdVP OzuHF0rlAna144EQXqZ7UPnU5LBJjVd1xOY4uPPWFTGIFbtiP2MTjovs22Km5Ea5WhvB 8nRwWLmtEqBYL2rjQh6OUfvzb2TTM48ZCyj3p5jRzQJ2bpWCk2AMUMKQOL/BhmOAxNih La7epN9mGEE7XxRjoN7Ms1CsdwWn9zCF+e7i9BKdjNmuyCy8f1WZXUAT2oFJP6M6iQE3 /EL+kXJBBqpqXE5s9On/xFYc3hK6aLdatEl68B/7pXo3uOfTD/lG1F9ZReQ4UkLpCKeW Po2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=VNle0uB1CHJfrgZZMNmGpGpI9dCcYAP5Bi4Y4IEYdBA=; b=O9A5PIf41QUWfvXe8v+aRhi1UngkrA1vb25hUeLXkYh4RHpDziAVlkKKy8ORbSuoHr zOejA7aX/zSj7MiijYael577+f+E/Zhi28n/N3TMuIabSKS/HLYx59J63nQTTXciWEb+ hfPIWTffFZ1PoeAUkW34dXyWumTfGjLBsz0PWiRaqSmuyDLDDx/M62UUncXLBagGsoM2 bnymaTl49NsgeuctP87mr132/+60IjGyrtkgPkbfX9mt8R/l5E+2P/26flWJs8ksNCDB pAA0s5n/F0wnjUQIjE/19L56WPl3T5uA14mA1wxwuuajq+amAXTToRCdksOSBA9pZbKx +anw== X-Gm-Message-State: ALyK8tKIYM76X0fiBbOxV1GZgdBUjx0BywBrNTsHlO/4sDKfQ9t14JerBt/YZwwg28Xu2A== X-Received: by 10.107.5.141 with SMTP id 135mr843832iof.91.1464835446564; Wed, 01 Jun 2016 19:44:06 -0700 (PDT) Original-Received: from [192.168.0.3] (174-23-122-197.slkc.qwest.net. [174.23.122.197]) by smtp.gmail.com with ESMTPSA id g7sm13493376itg.10.2016.06.01.19.44.04 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Jun 2016 19:44:04 -0700 (PDT) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118968 Archived-At: 1. Emacs -Q 2. Open a file with git history, say something in the Emacs repository. 3. Narrow to a region not at the beginning of the file 4. Select a region 5. M-x vc-region-history 6. Notice that the history shown is for the beginning of the file This is because vc-region-history uses line-number-at-pos which returns the line number in the narrowed portion of the buffer. We could either put a save-restriction/widen pair in vc-region-history or create a function (say widened-line-number-at-pos or file-line-number-at-pos), which would be generally useful IMO. However, that would lead to two calles to save-restriction and widen instead of just one. Given the recent discussion on emacs-devel about widening for programs I felt I should get some feed back on the preferred method before pushing a fix. -Ivan