all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Damien Cassou <damien@cassou.me>, 72116-done@debbugs.gnu.org
Subject: bug#72116: 30.0.60; Filling c-ts-mode documentation is broken
Date: Tue, 16 Jul 2024 21:18:27 -0700	[thread overview]
Message-ID: <2CE81709-A2EA-4855-830A-F05C69E8C922@gmail.com> (raw)
In-Reply-To: <86ttgrizjj.fsf@gnu.org>



> On Jul 14, 2024, at 11:44 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Damien Cassou <damien@cassou.me>
>> Date: Sun, 14 Jul 2024 20:23:09 +0200
>> 
>> Filling documentation in a c-ts-mode buffer doesn't insert the " * "
>> prefix. It works fine in c-mode. How to reproduce:
>> 
>> 1. Install the C treesitter grammar
>> 2. Start emacs with "emacs -Q"
>> 3. Open the attached file in a new buffer
>> 4. Run M-x c-ts-mode
>> 5. Move point to the middle of line 2
>> 6. Press M-q
> 
> You can work around this by enabling auto-fill-mode.  Then typing SPC
> at the end of the long line will produce the effect you want.
> 
> Yuan, can you please look into this?

Fixed and pushed to master. I didn’t push this to emacs-30 since adaptive-filling is a fragile being, so let’s wait and see :-)

> 
>> If you remove step 4 from the above instructions, c-mode will do the
>> work just fine.
> 
> In c-mode, M-q is bound to a c-mode specific function, which makes no
> sens in c-ts-mode.  We need a ts-specific solution (and we already
> seem to have it, it just isn't working in this case for some reason).

In c-ts-mode, M-q jumps a few hops, but it eventually calls c-ts-mode’s filling function (c-ts-common--fill-paragraph).

Yuan




      reply	other threads:[~2024-07-17  4:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-14 18:23 bug#72116: 30.0.60; Filling c-ts-mode documentation is broken Damien Cassou
2024-07-14 18:44 ` Eli Zaretskii
2024-07-17  4:18   ` Yuan Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2CE81709-A2EA-4855-830A-F05C69E8C922@gmail.com \
    --to=casouri@gmail.com \
    --cc=72116-done@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.