Re: src/nsterm.m: fix window tabbing on macOS

["Paul W. Rankin" via "Emacs development discussions." <emacs-devel@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]


> On 6 Jun 2021, at 4:14 pm, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Feedback-ID: 791:353:null:purelymail
>> Date: Sun, 6 Jun 2021 14:01:26 +1000
>> Cc: emacs-devel@gnu.org
>> From:  "Paul W. Rankin" via "Emacs development discussions." <emacs-devel@gnu.org>
>> 
>> ++++
>> +** On macOS, Emacs now supports native tabs (available in macOS 10.12
>> +and later).  Native tabbing behavior is specified system-wide via
>> +System Preferences, under under General > 'Prefer tabs when opening
>> +documents'. In macOS versions 10.15 and earlier, this option is
>> +located under Dock instead. Note that this feature is unrelated to the
>> +Emacs 'tab-bar-mode'.
> 
> Thanks.  A minor nit: since NEWS is displayed in Outline mode, the
> first sentence of any entry is its heading, and should not take more
> than one line.  If you have some details that make it longer, move
> those details to the subsequent lines.  For example:
> 
>  ** On macOS, Emacs now supports native tabs.
>  These tabs are available in macOS 10.12 and later.
>  ...

No problemo. Revised patch attached.


[-- Attachment #2: 0001-src-nsterm.m-fix-window-tabbing-on-macOS.patch --]
[-- Type: application/octet-stream, Size: 2063 bytes --]

From b2a9842399c3eafccab1964764ad383a37f26b11 Mon Sep 17 00:00:00 2001
From: "Paul W. Rankin" <pwr@bydasein.com>
Date: Sat, 8 May 2021 19:09:59 +1000
Subject: [PATCH] src/nsterm.m: fix window tabbing on macOS

* src/nsterm.m: remove NSWindowTabbingModeDisallowed to respect
  system-wide preferences
* etc/NEWS: add mention of native tab support in macOS and where
  to specify system-wide setting
---
 etc/NEWS     | 8 ++++++++
 src/nsterm.m | 8 --------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 32d7c4fe18..278cc5ea3c 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -3110,6 +3110,14 @@ The new variable 'xwidget-webkit-download-dir' says where to download to.
 'module-file-suffix' now has the value ".dylib" on macOS, but the
 ".so" suffix is supported as well.
 
++++
+** On macOS, Emacs now supports native tabs (in macOS 10.12 and later).
+Native tabbing behavior is specified system-wide via System
+Preferences, under under General > 'Prefer tabs when opening
+documents'. In macOS versions 10.15 and earlier, this option is
+located under Dock instead. Note that this feature is unrelated to the
+Emacs 'tab-bar-mode'.
+
 +++
 ** On MS-Windows, Emacs can now toggle the IME.
 A new function 'w32-set-ime-open-status' can now be used to disable
diff --git a/src/nsterm.m b/src/nsterm.m
index bb20886ab1..5fd4885801 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7628,14 +7628,6 @@ - (instancetype) initFrameFromEmacs: (struct frame *)f
          selector:@selector (viewDidResize:)
              name:NSViewFrameDidChangeNotification object:nil];
 
-  /* macOS Sierra automatically enables tabbed windows.  We can't
-     allow this to be enabled until it's available on a Free system.
-     Currently it only happens by accident and is buggy anyway.  */
-#ifdef NS_IMPL_COCOA
-  if ([win respondsToSelector: @selector(setTabbingMode:)])
-    [win setTabbingMode: NSWindowTabbingModeDisallowed];
-#endif
-
   ns_window_num++;
   return self;
 }
-- 
2.30.1