* bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
@ 2013-09-05 8:39 Bozhidar Batsov
2013-09-05 11:45 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Bozhidar Batsov @ 2013-09-05 8:39 UTC (permalink / raw)
To: 15270
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
Code like the following breaks font-locking logic of ruby-mode:
expected_source = <<-END.strip_indent
each do |x|
some_method
other_method
end
END
The second END gets highlighted as a constant, instead of a string. I guess the two consecutive ends cause the problem.
Here's a screenshot - http://i42.tinypic.com/122jeap.jpg
In GNU Emacs 24.3.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
of 2013-08-12 on Bozhidars-MacBook-Pro.local
Windowing system distributor `Apple', version 10.3.1187
Configured using:
`configure '--prefix=/usr/local/Cellar/emacs/24.3' '--without-dbus'
'--enable-locallisppath=/usr/local/share/emacs/site-lisp'
'--infodir=/usr/local/Cellar/emacs/24.3/share/info/emacs'
'--without-gnutls' '--with-ns' '--disable-ns-self-contained' 'CC=cc''
--
Cheers,
Bozhidar
[-- Attachment #2: Type: text/html, Size: 1612 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
2013-09-05 8:39 bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs Bozhidar Batsov
@ 2013-09-05 11:45 ` Dmitry Gutov
2013-09-05 11:48 ` Bozhidar Batsov
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2013-09-05 11:45 UTC (permalink / raw)
To: Bozhidar Batsov; +Cc: 15270
Bozhidar Batsov <bozhidar.batsov@gmail.com> writes:
> Code like the following breaks font-locking logic of ruby-mode:
>
> expected_source = <<-END.strip_indent
> each do |x|
> some_method
> other_method
> end
> END
>
> The second END gets highlighted as a constant, instead of a string. I
> guess the two consecutive ends cause the problem.
>
> Here's a screenshot - http://i42.tinypic.com/122jeap.jpg
WFM: http://i.imgur.com/YPsjoDS.png
Have you tried it in the current trunk?
The first END highlighting looks out of place, but it's caused by the
"Perl-ish keywords" rule.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
2013-09-05 11:45 ` Dmitry Gutov
@ 2013-09-05 11:48 ` Bozhidar Batsov
2013-09-05 13:06 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Bozhidar Batsov @ 2013-09-05 11:48 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 15270
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
I guess this is fixed in the trunk, but I think the highlighting of the first END in the heredoc should be corrected as well.
--
Cheers,
Bozhidar
On Thursday, September 5, 2013 at 2:45 PM, Dmitry Gutov wrote:
> Bozhidar Batsov <bozhidar.batsov@gmail.com (mailto:bozhidar.batsov@gmail.com)> writes:
>
> > Code like the following breaks font-locking logic of ruby-mode:
> >
> > expected_source = <<-END.strip_indent
> > each do |x|
> > some_method
> > other_method
> > end
> > END
> >
> > The second END gets highlighted as a constant, instead of a string. I
> > guess the two consecutive ends cause the problem.
> >
> > Here's a screenshot - http://i42.tinypic.com/122jeap.jpg
>
> WFM: http://i.imgur.com/YPsjoDS.png
>
> Have you tried it in the current trunk?
>
> The first END highlighting looks out of place, but it's caused by the
> "Perl-ish keywords" rule.
>
>
[-- Attachment #2: Type: text/html, Size: 1858 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
2013-09-05 11:48 ` Bozhidar Batsov
@ 2013-09-05 13:06 ` Dmitry Gutov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2013-09-05 13:06 UTC (permalink / raw)
To: Bozhidar Batsov; +Cc: 15270-done
Version: 24.4
On 05.09.2013 14:48, Bozhidar Batsov wrote:
> I guess this is fixed in the trunk, but I think the highlighting of the
> first END in the heredoc should be corrected as well.
Ok, fixed for heredocs (gave BEGIN/END lower priority).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-05 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 8:39 bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs Bozhidar Batsov
2013-09-05 11:45 ` Dmitry Gutov
2013-09-05 11:48 ` Bozhidar Batsov
2013-09-05 13:06 ` Dmitry Gutov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.