From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: build system observations Date: Wed, 6 Aug 2008 21:36:47 -0400 Message-ID: <2B6A2B11-2FF8-460C-9A69-B211E39473BB@gmail.com> References: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> <200808050513.m755Db39008109@sallyv1.ics.uci.edu> <56D8F202-EF53-439B-8EBB-11782EBCFE93@gmail.com> <200808061729.m76HT06A013042@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1218073046 24549 80.91.229.12 (7 Aug 2008 01:37:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Aug 2008 01:37:26 +0000 (UTC) Cc: emacs- devel To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 07 03:38:17 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KQuSB-0001nz-45 for ged-emacs-devel@m.gmane.org; Thu, 07 Aug 2008 03:38:11 +0200 Original-Received: from localhost ([127.0.0.1]:51180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQuRF-000647-OI for ged-emacs-devel@m.gmane.org; Wed, 06 Aug 2008 21:37:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQuRA-00060R-9M for emacs-devel@gnu.org; Wed, 06 Aug 2008 21:37:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQuR8-0005xf-JL for emacs-devel@gnu.org; Wed, 06 Aug 2008 21:37:07 -0400 Original-Received: from [199.232.76.173] (port=36604 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQuR8-0005xV-DW for emacs-devel@gnu.org; Wed, 06 Aug 2008 21:37:06 -0400 Original-Received: from an-out-0708.google.com ([209.85.132.250]:33830) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQuR8-0006Vv-2E for emacs-devel@gnu.org; Wed, 06 Aug 2008 21:37:06 -0400 Original-Received: by an-out-0708.google.com with SMTP id c38so35734ana.84 for ; Wed, 06 Aug 2008 18:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=aQt3KAIx5L2DvKJSmrcptZXylhrTaEsWIPL/5Ny6UWg=; b=sDCMGCGPeEOjfP4BWpv+D7F5Sz5iN2dvisrGoFpOnFiyMOdEEEyurTBCnhHFVyOqR0 gEpRR66DGImXRJlSAW+mvBTBqN4ujjWAjpVTf40u6/zzMNBfffDFiFLAduQkNBq0MCNP xGuMPUKEAJAk8qkoxK3Xiy/gSR+1ICFNtMp0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=BtL8sLzbsfU1BuMWcS7NjXkRy2ecSxZIHId//gtYb3W2ipGVQoZRbdMyslCP4ScZs+ HhlT8YoNw91iBY2k2bE3HE37xHyG6rz3Kf+bi6QHFh5ugMDP10ZCYt1JfzAvoR10FMgL s5SfYsxBM+g5HxOJ2kTPfVZULusBbHG3aX2dM= Original-Received: by 10.100.251.8 with SMTP id y8mr1413575anh.93.1218073025502; Wed, 06 Aug 2008 18:37:05 -0700 (PDT) Original-Received: from ?10.0.1.200? ( [97.73.30.9]) by mx.google.com with ESMTPS id b7sm16388569ana.35.2008.08.06.18.37.00 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 06 Aug 2008 18:37:04 -0700 (PDT) In-Reply-To: <200808061729.m76HT06A013042@sallyv1.ics.uci.edu> X-Mailer: Apple Mail (2.926) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102140 Archived-At: >>> # define GNU_OBJC_CFLAGS -fgnu-runtime -Wno-import -fconstant- >>> string-class=NSConstantString -DGNUSTEP_BASE_LIBRARY=1 - >>> DGNU_GUI_LIBRARY=1 -DGNU_RUNTIME=1 -DGSWARN -DGSDIAGNOSE >>> This is a new flag, better use autoconf substitions instead of >>> the preprocessor. >> >> I'm not sure how to do this, but have no objection to someone else >> making the change if it simplifies things. > > In configure.in: > GNU_OBJC_CFLAGS=... > AC_SUBST(GNU_OBJC_CFLAGS) > > and use @GNU_OBJC_CFLAGS@ in Makefile.in OK. Looking more closely there seems to be no pattern to when to use @...@ or #define. In configure.in there is: # ifdef NS_IMPL_GNUSTEP # define C_SWITCH_X_SYSTEM -D_REENTRANT -fPIC -fno-strict-aliasing # define GNU_OBJC_CFLAGS -fgnu-runtime -Wno-import ... ... Since C_SWITCH_X_SYSTEM is a #define, it seems simpler to keep them both the same, instead of adding several lines in various places to do autoconf substitution. Getting rid of the Makefile.c system should be an explicit project, done all at once. >>> # ifdef C_SWITCH_SYSTEM >>> # undef C_SWITCH_SYSTEM >>> # endif >>> >>> This sequence has not effect, it can be removed. >> >> This actually comes BEFORE the above definitions, and is to prevent >> redefinition errors. Some files under src/s define this, but they do >> so for X-Windows purposes. The NS port using GNUstep can be built on >> these systems and therefore needs to change the switch. > > Please look at how src/config.h is generated, it will have /* # > undef C_SWITCH_SYSTEM */ > so I think this never did anything. OK, I see your point. Removed. >> I'd welcome help on this one. I guess the Carbon port didn't need >> it, >> but despite NS using identical "path shenanigans" to the Carbon port, >> it didn't work there. Not sure what the problem is. > > First take it out, and then when people see the problem, someone might > help. It's just a warning, so it should not harm anyone. Out.