From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?David_K=E5gedal?= Newsgroups: gmane.emacs.devel Subject: Re: Is this tempo.el patch correct? Date: Fri, 9 Mar 2007 23:46:38 +0100 Message-ID: <2B5FE2FA-5F8E-45AF-9CAD-56630730421B@lysator.liu.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1173551794 10652 80.91.229.12 (10 Mar 2007 18:36:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2007 18:36:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 10 19:36:31 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HQ6Qg-0003Ro-Vb for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 19:36:31 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQ6R5-0003ck-Ea for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 13:36:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HPnrk-0007Ww-SW for emacs-devel@gnu.org; Fri, 09 Mar 2007 17:47:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HPnri-0007WY-SK for emacs-devel@gnu.org; Fri, 09 Mar 2007 17:47:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPnri-0007WU-KR for emacs-devel@gnu.org; Fri, 09 Mar 2007 17:47:10 -0500 Original-Received: from mail.lysator.liu.se ([130.236.254.3]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HPnrG-0002SE-Sy; Fri, 09 Mar 2007 17:46:43 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id B8DDC200A25B; Fri, 9 Mar 2007 23:46:39 +0100 (CET) Original-Received: from mail.lysator.liu.se ([127.0.0.1]) by localhost (lenin.lysator.liu.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 30889-01-67; Fri, 9 Mar 2007 23:46:38 +0100 (CET) Original-Received: from [192.168.1.187] (c83-253-22-207.bredband.comhem.se [83.253.22.207]) by mail.lysator.liu.se (Postfix) with ESMTP id 45DDE200A21C; Fri, 9 Mar 2007 23:46:38 +0100 (CET) In-Reply-To: X-Mailer: Apple Mail (2.752.3) X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at lysator.liu.se X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-Mailman-Approved-At: Sat, 10 Mar 2007 13:36:14 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67686 Archived-At: 9 mar 2007 kl. 22.26 skrev Richard Stallman: > David K}gedal, author of tempo.el, seems not to be responding, > so we are on our own unless someone can find a better way to =20 > contact him. > > Would someone please DTRT and then ack? I'm sorry. I'm here, and I put your mail on the pile of things to =20 take care of RSN. Since I haven't really done anything with tempo.el for ten years, it =20 takes a bit of mental effort to review patches. But I'll have a look =20= tomorrow. > ------- Start of forwarded message ------- > To: emacs-pretest-bug@gnu.org > From: Lawrence Mitchell > Date: Fri, 02 Mar 2007 14:39:11 +0000 > MIME-Version: 1.0 > Content-Type: text/plain; charset=3Dus-ascii > Subject: r> insertion marker not handled correctly in tempo > X-Spam-Status: No, score=3D0.0 required=3D5.0 tests=3Dnone = autolearn=3Dfailed > version=3D3.0.4 > > > If you define a tempo template that includes the "r>" insertion > marker, attempting to use that template results in an error that the > function "r>" is undefined. > > This bug may be reproduced as follows: > > emacs -Q > > Evaluate: > > (progn > (require 'tempo) > (tempo-define-template > "show-bug" > '("Some string" n> (r> "body: "))) > (setq debug-on-error t) > (tempo-template-show-bug)) > > > The following patch fixes this problem in, I believe, the correct > manner: > > Index: tempo.el > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /sources/emacs/emacs/lisp/tempo.el,v > retrieving revision 1.20.6.11 > diff -c -r1.20.6.11 tempo.el > *** tempo.el 26 Jan 2007 06:15:15 -0000 1.20.6.11 > - --- tempo.el 2 Mar 2007 14:36:39 -0000 > *************** > *** 352,357 **** > - --- 352,364 ---- > (goto-char tempo-region-stop) > (tempo-insert-prompt-compat > (cdr element)))) > + ((and (consp element) > + (eq (car element) 'r>)) (if on-region > + (progn > + (goto-char tempo-=20 > region-stop) > + (indent-region (mark) =20= > (point) nil)) > + (tempo-insert-prompt-compat > + (cdr element)))) > ((and (consp element) > (eq (car element) 's)) (tempo-insert-named (car (cdr =20 > element)))) > ((and (consp element) > > Changelog entry: > > 2007-03-02 Lawrence Mitchell > > * tempo.el (tempo-insert): Deal with 'r> if it appears > specified with a prompt argument. > > > Cheers, > > Lawrence > > - -- > Lawrence Mitchell > > > _______________________________________________ > emacs-pretest-bug mailing list > emacs-pretest-bug@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug > ------- End of forwarded message ------- > --=20 David K=E5gedal davidk@lysator.liu.se