From: "Drew Adams" <drew.adams@oracle.com>
To: "'Eli Zaretskii'" <eliz@gnu.org>
Cc: 14032@debbugs.gnu.org
Subject: bug#14032: 24.3.50; regression: `modify-frame-parameters' no longer works correctly
Date: Fri, 22 Mar 2013 14:40:52 -0700 [thread overview]
Message-ID: <2B2A9C71087149A3AEB106E10EA705FA@us.oracle.com> (raw)
In-Reply-To: <1584CB2485A643EF975AFAC4DE5C8295@us.oracle.com>
OK, here is a recipe from emacs -Q:
Load these three source files, in order: frame-fns.el, frame-cmds.el,
thumb-frm.el. They are available here:
http://www.emacswiki.org/emacs/?action=elisp-area;context=0
Visit a lisp file in a separate frame (e.g. C-x 5 f).
Manually resize the lisp-file frame to be wider and taller than the default
size, enough so you will notice the difference (quite large, if you want).
C-z to thumbify the frame. C-z to dethumbify it. It should be as it was before
thumbification: same position, height, and width. It is not - it seems to be
the default frame size.
That's the regression.
It's as if some parameters from `default-frame-alist' were being substituted for
some of the parameters provided explicitly to `modify-frame-parameters'. ("It's
as if..." - I don't say that that is what is actually happening.)
The frame parameters before thumbifying are recorded on list
`thumfr-thumbnail-frames': there is an alist entry for each thumbnail frame; the
cdr is the list of frame parameters before that frame was thumbified.
It is those pre-thumbification parameters that are passed to
`modify-frame-parameters' when you hit C-z the second time (command
`iconify-or-deiconify-frame', which calls `thumfr-toggle-thumbnail-frame', which
calls `thumfr-dethumbify-frame', which calls (modify-frame-parameters frame
non-tf-params), where FRAME is the selected frame and NON-TF-PARAMS is the list
of frame parameters recorded before thumbification.
If you prefer, select the name "thumfr-dethumbify-frame", then thumbify, then
M-x C-y RET to call `thumfr-dethumbify-frame' directly. Same wrong size
restored.
HTH.
next prev parent reply other threads:[~2013-03-22 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 18:57 bug#14032: 24.3.50; regression: `modify-frame-parameters' no longer works correctly Drew Adams
2013-03-22 20:06 ` Eli Zaretskii
2013-03-22 21:14 ` Drew Adams
2013-03-22 21:40 ` Drew Adams [this message]
2013-03-23 9:07 ` Eli Zaretskii
2013-03-23 15:07 ` Drew Adams
2013-04-10 15:43 ` Eli Zaretskii
2013-04-10 20:50 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2B2A9C71087149A3AEB106E10EA705FA@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=14032@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.