From: Lennart Staflin <lenst@lysator.liu.se>
Subject: broken menu items
Date: Fri, 12 Sep 2003 13:21:43 +0200 [thread overview]
Message-ID: <2ACF7139-0A55-11D8-8132-00039343C89C@lysator.liu.se> (raw)
I sent this to emacs-pretest-bug, but got no response.
In GNU Emacs 21.3.50.7 (powerpc-apple-darwin6.6)
of 2003-09-11 on Saturn.local.
configured using `configure '--enable-carbon-app' 'CC=cc
-traditional-cpp' 'CFLAGS=-g' 'CPPFLAGS=-traditional-cpp''
Some of the entries in menu bar of the Carbon port of Emacs
seems to do nothing. Like the "Edit > Select All".
I had a closer look at this and it seems that it is a call to
SetMenuItemRefCon in add_menu_item that is misplaced, it is called even
for separators, but for these a parameter is not set but has the same
value as for the preceding item (hmm. it is actually uninitialized,
must be reusing the same stack position). This clobbers the preceding
item.
Moving the call to SetMenuItemRefCon seems to fix this.
2003-09-12 Lennart Staflin <lenst@lysator.liu.se>
* macmenu.c (add_menu_item): Don't call SetMenuItemRefCon for
separators, as the pos parameter will be incorrect.
*** macmenu.c.~1.11.~ Sat Aug 30 20:18:53 2003
--- macmenu.c Thu Sep 11 21:54:46 2003
***************
*** 2281,2289 ****
else
SetItemMark (menu, pos, noMark);
}
- }
! SetMenuItemRefCon (menu, pos, (UInt32) wv->call_data);
if (submenu != NULL)
SetMenuItemHierarchicalID (menu, pos, submenu);
--- 2281,2289 ----
else
SetItemMark (menu, pos, noMark);
}
! SetMenuItemRefCon (menu, pos, (UInt32) wv->call_data);
! }
if (submenu != NULL)
SetMenuItemHierarchicalID (menu, pos, submenu);
reply other threads:[~2003-09-12 11:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ACF7139-0A55-11D8-8132-00039343C89C@lysator.liu.se \
--to=lenst@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.