From: "Mattias Engdegård" <mattiase@acm.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Scan of broken conditional forms
Date: Sat, 4 Jan 2020 23:04:00 +0100 [thread overview]
Message-ID: <2A6F7832-4F3B-4EB3-A3AC-9F4EF7FBBF51@acm.org> (raw)
In-Reply-To: <1abe6fdc-7466-193a-cbd3-4e2d3bf2660b@cs.ucla.edu>
4 jan. 2020 kl. 20.23 skrev Paul Eggert <eggert@cs.ucla.edu>:
> smime-encrypt-buffer always returns nil (it signals an error on failure), so
> that code happens to work though it is too complicated.
Oh, right --- I was led astray by the code that looked at the return value.
> I fixed that issue along with the others (other than the two that you and
> Michael already fixed) by installing the attached into the emacs-27 branch.
Thank you, and the changes seem fine as far as I can tell.
One point though: Doesn't ede-proj-configure-test-required-file strike you as a bit backwards? It creates a file, and then asks for permission afterwards (easier to obtain forgiveness...), despite the assurances in the docstring of ede-pconf-create-file-query. The actual condition logic is bonkers, too (the 'never' value has the same effect as nil).
next prev parent reply other threads:[~2020-01-04 22:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 12:37 Scan of broken conditional forms Mattias Engdegård
2020-01-04 13:03 ` Michael Albinus
2020-01-04 19:23 ` Paul Eggert
2020-01-04 19:39 ` Eli Zaretskii
2020-01-04 21:40 ` Paul Eggert
2020-01-05 15:45 ` Eli Zaretskii
2020-01-05 20:48 ` Paul Eggert
2020-01-05 20:57 ` Stefan Monnier
2021-01-27 3:02 ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Stefan Monnier
2021-01-27 8:18 ` Broken `if big5-p` code in titdic-cnv.el Andreas Schwab
2021-01-27 16:16 ` Broken `if big5-p` code in titdic-cnv.el (was: Scan of broken conditional forms) Eli Zaretskii
2021-01-27 17:35 ` Broken `if big5-p` code in titdic-cnv.el Stefan Monnier
2020-01-04 22:04 ` Mattias Engdegård [this message]
2020-01-04 22:11 ` Scan of broken conditional forms Paul Eggert
2020-01-31 16:22 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2A6F7832-4F3B-4EB3-A3AC-9F4EF7FBBF51@acm.org \
--to=mattiase@acm.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.