From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs Subject: bug#4736: 23.1; ns-antialias-text set to nil has no effect Date: Sun, 14 Feb 2010 10:38:38 -0500 Message-ID: <2A6D0821-4E99-48D0-A710-2D01006A09E4__41633.8006187745$1266162769$gmane$org@gmail.com> References: <3D80FB40-724F-4789-8807-E1C8A8A40375@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-46-91910322" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1266162767 29740 80.91.229.12 (14 Feb 2010 15:52:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Feb 2010 15:52:47 +0000 (UTC) Cc: Adrian Robert , John Whitley , 4736@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Francis Devereux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 14 16:52:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nggm3-0003Em-Hc for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Feb 2010 16:52:43 +0100 Original-Received: from localhost ([127.0.0.1]:33350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nggm3-0000Ar-3O for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Feb 2010 10:52:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nggly-00009v-MK for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2010 10:52:38 -0500 Original-Received: from [140.186.70.92] (port=49991 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nggly-00009K-10 for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2010 10:52:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ngglx-0008CR-ID for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2010 10:52:37 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58075) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ngglx-0008CN-Eh for bug-gnu-emacs@gnu.org; Sun, 14 Feb 2010 10:52:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NggYo-00038a-9E; Sun, 14 Feb 2010 10:39:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: David Reitter Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2010 15:39:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 4736 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Original-Received: via spool by 4736-submit@debbugs.gnu.org id=B4736.126616193912053 (code B ref 4736); Sun, 14 Feb 2010 15:39:02 +0000 Original-Received: (at 4736) by debbugs.gnu.org; 14 Feb 2010 15:38:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NggYl-00038M-GL for submit@debbugs.gnu.org; Sun, 14 Feb 2010 10:38:59 -0500 Original-Received: from mail-vw0-f50.google.com ([209.85.212.50]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NggYj-00038E-P2 for 4736@emacsbugs.donarmstrong.com; Sun, 14 Feb 2010 10:38:58 -0500 Original-Received: by vws2 with SMTP id 2so1621941vws.37 for <4736@emacsbugs.donarmstrong.com>; Sun, 14 Feb 2010 07:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-pgp-agent:x-mailer; bh=c6ngL68eTgZXT6TlwuMQzSC57/eWnlUT42AnxCOCT9E=; b=GJnJKH6BqzrfCixEFJ+QYjcZHn0GcceHyflR0lNQbGQii3n4JyiPLemqQKIVvrw6FB 9lovWjUYw6SoQL/uqiR8+Fv17ABTEJoHgeCA1gD8o0Td3ZrotCjYRKRFMRKsr3QMMwcn YncpEhsRiz3GUd3JBlpgY5hYBTIb/RcISsyB0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-pgp-agent :x-mailer; b=jKSlNajeY6sCICMS6tkaoV1mkcBMjllWV/YsaG+TVkhpXZEA6Pfo8SswYJ2xxIHoiW n0TJrUDXrkdFjiF9MSbQL69eoSIJiu8ih8j9SO3L1cpI0TkdP4M895byvlr/ndFdLX7Q AKK2WCAPURnebsHcfbbHk84/WaNkGQ36hNg7s= Original-Received: by 10.220.48.213 with SMTP id s21mr2776589vcf.105.1266161932454; Sun, 14 Feb 2010 07:38:52 -0800 (PST) Original-Received: from ?192.168.1.42? (pool-96-236-181-152.pitbpa.east.verizon.net [96.236.181.152]) by mx.google.com with ESMTPS id 37sm55660488vws.7.2010.02.14.07.38.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 14 Feb 2010 07:38:50 -0800 (PST) In-Reply-To: X-Pgp-Agent: GPGMail 1.2.3 X-Mailer: Apple Mail (2.1077) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 14 Feb 2010 10:39:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:35110 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-46-91910322 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Feb 14, 2010, at 8:31 AM, Francis Devereux wrote: > On 17 Oct 2009, at 13:16, Adrian Robert wrote: >=20 >> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4736 >=20 > I've also discovered that if I build Emacs as a 32 bit binary on 10.6 = (the default is 64 bit on 10.6) with the following command then = ns-antialias-text works. The commands I used to build are: > LDFLAGS=3D"-arch i386" CFLAGS=3D"-g -O2 -arch i386 -march=3Dcore2" = ../trunk/configure --build=3Di386-apple-darwin10.2.0 --with-ns && make = -j2 && make install ns_antialias_text is wrongly declared as an int instead of Lisp_Object, = and the nonstandard pointer comparison to Qnil helped cover it up, I = suppose. That also explains why it happened to work on 32bit. Try the = patch below. diff --git a/src/nsfont.m b/src/nsfont.m index 934fefa..1b157ce 100644 --- a/src/nsfont.m +++ b/src/nsfont.m @@ -50,7 +50,7 @@ extern Lisp_Object Qnormal, Qbold, Qitalic, = Qcondensed, Qexpanded; static Lisp_Object Vns_reg_to_script; static Lisp_Object Qapple, Qroman, Qmedium; extern Lisp_Object Qappend; -extern int ns_antialias_text; +extern Lisp_Object ns_antialias_text; extern float ns_antialias_threshold; extern int ns_tmp_flags; extern struct nsfont_info *ns_tmp_font; @@ -1243,7 +1245,7 @@ nsfont_draw (struct glyph_string *s, int from, int = to, int x, int y, =20 CGContextSetFont (gcontext, font->cgfont); CGContextSetFontSize (gcontext, font->size); - if (ns_antialias_text =3D=3D Qnil || font->size <=3D = ns_antialias_threshold) + if (NILP (ns_antialias_text) || font->size <=3D = ns_antialias_threshold) CGContextSetShouldAntialias (gcontext, 0); else CGContextSetShouldAntialias (gcontext, 1); --Apple-Mail-46-91910322 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.12 (Darwin) iEYEARECAAYFAkt4GQUACgkQYotoJUVQB4LO9ACeMs83UGkpN6Wb7R0UsVPZ9Pd/ WmcAoOSpQta3BlxJN3U24vqdUMRNdVCK =+irU -----END PGP SIGNATURE----- --Apple-Mail-46-91910322--