From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35784: emacs 26 crash Date: Sun, 19 May 2019 07:51:21 +0300 Message-ID: <2A54F0AC-6D10-45CA-B0BD-DA3D445FF96C@gnu.org> References: <1558126467.3148.9.camel@bloodnok.com> <83ftpc9ted.fsf@gnu.org> <87zhnkc5zg.fsf@gmail.com> <87woindevp.fsf@gmail.com> <83y33393g0.fsf@gnu.org> <07948e24-aeab-9ac8-9d0d-b3a704c58b08@gmx.at> <87ftpbcfwc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="66589"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: K-9 Mail for Android Cc: 35784@debbugs.gnu.org, marc@bloodnok.com To: Noam Postavsky ,martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 19 06:52:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSDnu-000H8G-BH for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 06:52:10 +0200 Original-Received: from localhost ([127.0.0.1]:43886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSDnt-0006Ob-A0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 00:52:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSDnn-0006OW-JL for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 00:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSDnm-00013U-JL for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 00:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSDnm-00013P-GN for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 00:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hSDnm-0003fg-By for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 00:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2019 04:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35784 X-GNU-PR-Package: emacs Original-Received: via spool by 35784-submit@debbugs.gnu.org id=B35784.155824149314079 (code B ref 35784); Sun, 19 May 2019 04:52:02 +0000 Original-Received: (at 35784) by debbugs.gnu.org; 19 May 2019 04:51:33 +0000 Original-Received: from localhost ([127.0.0.1]:33596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSDnI-0003f1-UK for submit@debbugs.gnu.org; Sun, 19 May 2019 00:51:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSDnG-0003ep-V7 for 35784@debbugs.gnu.org; Sun, 19 May 2019 00:51:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58376) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSDnB-0000tu-El; Sun, 19 May 2019 00:51:25 -0400 Original-Received: from [176.12.219.164] (port=36755 helo=[10.209.164.91]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1hSDnA-0004k8-QY; Sun, 19 May 2019 00:51:25 -0400 In-Reply-To: <87ftpbcfwc.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159523 Archived-At: On May 19, 2019 5:54:59 AM GMT+03:00, Noam Postavsky = wrote: > >>> #2 0x000000000061849e in die (msg=3D0x743f3f "BUFFERP (a)", > >>> file=3D0x743f36 "buffer=2Eh", line=3D914) at alloc=2Ec:7406 > >>> #3 0x00000000005802b3 in XBUFFER (a=3D0) at buffer=2Eh:914 > >>> #4 0x0000000000468bb3 in mark_window_display_accurate_1 > (w=3D0x558e410, > >>> accurate_p=3Dfalse) at xdisp=2Ec:14754 > >>> b =3D 0x7ffe74b60e40 > >>> #5 0x0000000000468ffd in mark_window_display_accurate > >>> (window=3D89711637, accurate_p=3Dfalse) at xdisp=2Ec:14811 > >>> w =3D 0x558e410 > >>> #6 0x00000000004bbe06 in Fforce_window_update (object=3D89711637) > at > >>> window=2Ec:3643 > >>> w =3D 0x558e410 > >> > >> This seems to imply that we are trying to update a non-leaf window, > >> something that should never happen=2E There's no Lisp-level > backtrace, > >> so it's hard to tell what Lisp called force-window-update, and how > the > >> window in question became non-leaf, but maybe some crazy Lisp hook > >> switched windows behind redisplay's back or something=2E > > > > I'd rather guess that this is the result of 'kill-buffer' called > from > > 'delete-frame-functions' or 'delete-frame' called from > > 'kill-buffer-hook'=2E But at the moment I can't reproduce the bug > here > > any more=2E >=20 > The Lisp backtrace is: >=20 > "force-window-update" (0xffffd640) > 0x2f61c80 Lisp type 3 > "mapc" (0xffffd960) > "k-tabbar2::pc-handle-queued-updates" (0xffffdb00) > "k-tabbar2::post-command-fn" (0xffffddf0) >=20 > I think the problem is just that the Lisp code is calling > force-window-update on a deleted window=2E At least, I can trigger the > crash with >=20 > (let ((w (split-window))) > (delete-window w) > (force-window-update w)) >=20 > And the following fixes it: >=20 > --- i/src/window=2Ec > +++ w/src/window=2Ec > @@ -4089,7 +4089,7 @@ displaying that buffer=2E */) > return Qt; > } > =20 > - if (WINDOWP (object)) > + if (WINDOW_LIVE_P (object)) > { > struct window *w =3D XWINDOW (object); > mark_window_display_accurate (object, false); Thanks, this fix is fine with me=2E Martin?