From: Kai Ma <justksqsf@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: Po Lu <luangruo@yahoo.com>,
63187@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Aaron Jensen <aaronjensen@gmail.com>
Subject: bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS
Date: Fri, 9 Jun 2023 10:42:08 +0800 [thread overview]
Message-ID: <2A505E20-55E2-4788-A21C-B94068299E50@gmail.com> (raw)
In-Reply-To: <ZIIOa7B9r+XB1/j6@idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 2437 bytes --]
> On Jun 9, 2023, at 01:22, Alan Third <alan@idiocy.org> wrote:
>
> On Thu, Jun 08, 2023 at 10:57:43PM +0800, Kai Ma wrote:
>>
>>
>>> On Jun 8, 2023, at 21:42, Kai Ma <justksqsf@gmail.com> wrote:
>>>
>>>
>>>> On Jun 8, 2023, at 20:51, Alan Third <alan@idiocy.org> wrote:
>>>>
>>>> I've got two things it could be worth trying to see if they make any
>>>> difference.
>>>> Change the CACHE_MAX_SIZE to something greater than 2, probably 4 is a
>>>> good number. That would rule out some sort of locking problem, as it
>>>> would reduce the chance a surface would be re-used before it's been
>>>> sent to the screen.
>>>>
>>>> The downside of this is probably going to be an increase in "lag"
>>>> because it's possible to have more surfaces "in-flight".
>>>>
>>>> The other option is to remove this call (nsterm.m:10636):
>>>>
>>>> /* Schedule a run of getContext so that if Emacs is idle it will
>>>> perform the buffer copy, etc. */
>>>> [self performSelectorOnMainThread:@selector (getContext)
>>>> withObject:nil
>>>> waitUntilDone:NO];
>>>>
>>>> I think this is harmless, but it's in there as I *assume*, with
>>>> absolutely no proof, that it will improve performance and it seems
>>>> possible (but I think unlikely) that it may affect the sequencing of
>>>> surface operations.
>>>
>>> Tested locally. I can confirm that removing
>>> performSelectorOnMainThread (with CACHE_MAX_SIZE = 2) fixes the
>>> problem for me. I now observe zero glitches or tearings!
>>>
>>
>> Sorry, I concluded too fast. I can still see tearings, though very
>> rarely. So this is still not a real fix. :-(
>
> Try increasing CACHE_MAX_SIZE too. Tearing would, I believe, be
> because a surface is being reused while it's still being copied to the
> VRAM, so you'll see a partially modified output.
>
> If increasing CACHE_MAX_SIZE fixes it then there are a couple of
> possible options we can look at.
Increasing CACHE_MAX_SIZE alone doesn’t seem to help much.
(Screencast: https://www.youtube.com/watch?v=9YD9jyP-GKw)
Increasing CACHE_MAX_SIZE + Removing performSelectorOnMainThread seems to be better but I can’t be sure. Just observed:
(1) M-< at the mid of a buffer, but only the first line of the view is refreshed, and other parts were still there.
(2) selecting a region doesn’t always clear the hl-line effect.
[-- Attachment #2: hl-line.png --]
[-- Type: image/png, Size: 76619 bytes --]
[-- Attachment #3: Type: text/plain, Size: 3 bytes --]
next prev parent reply other threads:[~2023-06-09 2:42 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m2fs8histt.fsf@gmail.com>
2023-04-30 10:33 ` bug#63187: 30.0.50; Tail of longer lines painted after end of nearby lines on macOS Eli Zaretskii
2023-04-30 10:46 ` Aaron Jensen
2023-04-30 13:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-30 14:25 ` Aaron Jensen
2023-04-30 14:42 ` Eli Zaretskii
2023-04-30 14:57 ` Aaron Jensen
2023-04-30 15:26 ` Eli Zaretskii
2023-04-30 16:48 ` Aaron Jensen
2023-04-30 19:04 ` Eli Zaretskii
2023-04-30 23:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-01 12:40 ` Eli Zaretskii
2023-05-01 13:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-01 13:25 ` Eli Zaretskii
2023-05-01 13:47 ` Aaron Jensen
2023-05-01 13:52 ` Eli Zaretskii
2023-05-01 13:55 ` Aaron Jensen
2023-05-01 14:06 ` Aaron Jensen
2023-05-09 3:07 ` Aaron Jensen
2023-05-09 5:39 ` Eli Zaretskii
2023-05-13 13:54 ` Eli Zaretskii
2023-05-13 14:23 ` Aaron Jensen
2023-05-18 11:21 ` Eli Zaretskii
2023-05-18 15:59 ` Aaron Jensen
2023-06-08 5:40 ` Kai Ma
2023-06-08 7:33 ` Kai Ma
2023-06-08 12:51 ` Alan Third
2023-06-08 13:42 ` Kai Ma
2023-06-08 14:57 ` Kai Ma
2023-06-08 17:22 ` Alan Third
2023-06-09 2:42 ` Kai Ma [this message]
2023-06-09 2:47 ` Aaron Jensen
2023-06-09 3:12 ` Kai Ma
2023-06-09 18:27 ` Alan Third
2023-06-09 18:46 ` Aaron Jensen
2023-06-09 20:00 ` Alan Third
2023-06-12 13:04 ` Aaron Jensen
2023-06-16 2:17 ` Aaron Jensen
2023-06-19 15:46 ` Aaron Jensen
2023-06-24 4:17 ` Kai Ma
2023-06-24 13:34 ` Aaron Jensen
2023-06-24 14:14 ` Alan Third
2023-06-24 14:52 ` Aaron Jensen
2023-06-24 15:08 ` Eli Zaretskii
2023-06-24 15:41 ` Alan Third
2023-06-24 16:05 ` Aaron Jensen
2023-06-24 21:29 ` Alan Third
2023-06-24 21:43 ` Aaron Jensen
2023-06-25 12:46 ` Alan Third
2023-06-25 17:07 ` Aaron Jensen
2023-06-25 18:17 ` Alan Third
2023-06-25 19:07 ` Aaron Jensen
2023-06-25 21:18 ` Alan Third
2023-06-25 22:33 ` Aaron Jensen
2023-06-26 7:27 ` Kai Ma
2023-06-28 19:53 ` Alan Third
2023-07-21 2:02 ` Aaron Jensen
2023-07-23 11:20 ` Alan Third
2023-07-23 13:01 ` Aaron Jensen
2023-07-25 14:47 ` Aaron Jensen
2023-07-25 15:45 ` Eli Zaretskii
2023-06-23 8:48 ` Alan Third
2023-06-23 11:54 ` Aaron Jensen
2023-05-01 17:26 ` Alan Third
2023-05-01 22:40 ` Aaron Jensen
2023-05-02 10:14 ` Alan Third
2023-05-02 12:21 ` Eli Zaretskii
2023-05-02 22:36 ` Alan Third
2023-05-03 8:11 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-03 13:08 ` Eli Zaretskii
2023-05-02 0:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-02 0:32 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2A505E20-55E2-4788-A21C-B94068299E50@gmail.com \
--to=justksqsf@gmail.com \
--cc=63187@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.