From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Thu, 21 Nov 2019 01:37:13 +0200 Message-ID: <29e2e877-6dc3-b03b-7463-01cff35e05d1@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51492"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org To: Juri Linkov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 00:38:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXZYC-000D5Z-Di for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 00:38:20 +0100 Original-Received: from localhost ([::1]:35056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXZY9-00069b-VC for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 18:38:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53606) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXZY1-00065f-9G for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:38:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXZXv-0001rJ-Py for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:38:09 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42268) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXZXt-0001qk-Uh for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXZXt-0007Iu-Qn for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 18:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 23:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157429304728024 (code B ref 38044); Wed, 20 Nov 2019 23:38:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 23:37:27 +0000 Original-Received: from localhost ([127.0.0.1]:51089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZXK-0007Hw-Q3 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 18:37:26 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:33003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZXG-0007Hc-Pl for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 18:37:23 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id t26so2369080wmi.0 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 15:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Wok/0m8BLfZtek+di9AAEtGxhWejoVRsNIyAE4tSlc8=; b=LJiEIj0OoOB55z3DZI7NvFYRQngdJC3cwhJXS9rxtliPcaanT5sDB2Yxh58lQwI4X7 KMRTy5zRxImDefIAt9WxvZKK0l7rNPlvH+/UFnwsMj1Va4prqAdrO4793jqfsHoH61PF iOCFNMpcXCPFOJxtKG47qbpTW1kfqikU1zbhOD8J75e8mcU0/FwPbpC5bEHWN+aKKjEd zcOzGj4oYMSAMfhA2+f+r/JSGKWfSGF1tKodK5QHTYtCxP02kclEDUhY1+xgakIrsU65 4YjsdC9SJtT4rH7nhZmJNLfKqi4ZVFqx84tgpieVwGUhhtfuzsxT0RH4Pi3CkIlEEHjv KWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wok/0m8BLfZtek+di9AAEtGxhWejoVRsNIyAE4tSlc8=; b=mt7RQT2oLfvgEvZAEJM6vZbExRwbNi2OSLo0wxxBlg+/l+3oRnI9GU5FMLwAUxf6G6 3dC+q0OqHToZN+iYS/9XrzyQnhYETkmcuQnWsuxgVTXGbIefjQuqb54e68VsZEwRMyJv k6XjtR8zEXRMdnsjg/Se3Irqj90VAaEyEBKSsG1Ii7pP7lLYIzBbYero88DQzih/tsa0 3xbt/zoVT73J9s8BvvXSiHxpGKU/tjevD7JNbhepsO0I90ZWs7SiT9i7nyVUrMV90Aqn iSMTxjWzfXjmDHA32l+2wGBUM0LnvrDAt6TNGryQ8s8xloxua+gLVLU2LXMNVlXNykZd gepA== X-Gm-Message-State: APjAAAW6sdOQ0hq5LcUpPg/pstTX+iKPUv5kJWapBFpysI57VzPDhNE/ vJGOu14odd5S2aAUKk0siB+9Oi30 X-Google-Smtp-Source: APXvYqzOTSrBqWmbpPjtT6PTtGpfwEznxiFPVN+KMWXbW8HyhShkKwN3gl3bvPysp2sMgBu6X5Ss2A== X-Received: by 2002:a05:600c:2919:: with SMTP id i25mr6306496wmd.158.1574293035922; Wed, 20 Nov 2019 15:37:15 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id l4sm924789wme.4.2019.11.20.15.37.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 15:37:15 -0800 (PST) In-Reply-To: <87y2warzv3.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172087 Archived-At: Hi Juri, The approach LGTM. I'd have used "describe" or "show", but it's not important. Some minor nits: On 20.11.2019 23:50, Juri Linkov wrote: > (setq default-directory rootdir) This probably needs a saving (let ((default-directory default-directory)) ...) above it. > +With a prefix argument, ask for a command to run that will output > +the revision information." This sentence should be into the docstring of the new command, not in the backend implementation. > + (read-shell-command > + "Show revision with command: " > + (format "%s %s" vc-git-program > + (mapconcat 'identity args " ")) > + 'vc-git-history) > + " " t)))) If wonder if some user someday is going to try and input there something that doesn't start with 'git '.