From: Paul Maragakis via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 52067@debbugs.gnu.org
Subject: bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings
Date: Wed, 24 Nov 2021 10:15:07 -0500 [thread overview]
Message-ID: <29E98EEC-07C6-4270-9B23-A9734CFC9279@icloud.com> (raw)
In-Reply-To: <87a6huvwls.fsf_-_@gnus.org>
Excellent---and thanks for the explanation!
I confirm that the latest Emacs 29 fixes the bug.
You can close this ticket.
Paul
> On Nov 24, 2021, at 2:30 AM, Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Paul Maragakis <paul.maragakis@icloud.com> writes:
>
>> The logic in string-glyph-split expects the first two elements in the result
>> from find-composition-internal to give the start and end of a multibyte grapheme
>> and return nil when there is a regular character at position POS. However, this
>> isn't always the case.
>
> Yup.
>
> Paul Maragakis <paul.maragakis@icloud.com> writes:
>
>> The following code fixes this bug, though there might be better ways
>> to fix it for someone who understands the domain.
>
> Thanks. `find-composition' takes a the LIMIT parameter, and that'll
> make it avoid searching back into the bit of the string that we've
> already handled. So I did that instead in Emacs 29.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
> bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-24 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 23:01 bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings PAVLOS MARAGAKIS via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.52067.B.16377084873203.ack@debbugs.gnu.org>
2021-11-24 3:51 ` bug#52067: Acknowledgement (29.0.50; string-glyph-split halts on certain emoji strings) Paul Maragakis via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 7:30 ` bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings Lars Ingebrigtsen
2021-11-24 15:15 ` Paul Maragakis via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-24 16:14 ` Lars Ingebrigtsen
2021-11-24 4:58 ` bug#52067: possible fix for " Paul Maragakis via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29E98EEC-07C6-4270-9B23-A9734CFC9279@icloud.com \
--to=bug-gnu-emacs@gnu.org \
--cc=52067@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=paul.maragakis@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.