From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pierre-Yves Newsgroups: gmane.emacs.bugs Subject: bug#18120: cua-rect.el issue on help Date: Sun, 27 Jul 2014 23:54:32 +0200 Message-ID: <299BAB7F-F8D4-4029-9E7D-1C076ECF17EC@luyten.fr> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_B50E3582-5168-42E2-8472-F942B934B140" X-Trace: ger.gmane.org 1406506894 26905 80.91.229.3 (28 Jul 2014 00:21:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jul 2014 00:21:34 +0000 (UTC) To: 18120@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 28 02:21:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBYgw-0002kp-Rt for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 02:21:27 +0200 Original-Received: from localhost ([::1]:37073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYgv-0001XK-QY for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jul 2014 20:21:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYgj-0001WI-B4 for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:21:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBYgZ-0007hq-0z for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:21:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYgY-0007hm-Tp for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XBYgY-00063Y-IW for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pierre-Yves Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jul 2014 00:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 18120 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.140650685523252 (code B ref -1); Mon, 28 Jul 2014 00:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Jul 2014 00:20:55 +0000 Original-Received: from localhost ([127.0.0.1]:39724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBYgP-00062w-Ff for submit@debbugs.gnu.org; Sun, 27 Jul 2014 20:20:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBWPR-0002XD-Bj for submit@debbugs.gnu.org; Sun, 27 Jul 2014 17:55:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBWPB-0004Hr-Nm for submit@debbugs.gnu.org; Sun, 27 Jul 2014 17:55:07 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:38655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBWPB-0004Hl-KC for submit@debbugs.gnu.org; Sun, 27 Jul 2014 17:54:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBWP2-0002VO-Qb for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 17:54:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBWOu-0004Gs-3d for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 17:54:48 -0400 Original-Received: from 18.mo3.mail-out.ovh.net ([87.98.172.162]:53746 helo=mo3.mail-out.ovh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBWOt-0004Gd-Po for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 17:54:40 -0400 Original-Received: from mail614.ha.ovh.net (gw6.ovh.net [213.251.189.206]) by mo3.mail-out.ovh.net (Postfix) with SMTP id 81C74FF8B23 for ; Sun, 27 Jul 2014 23:54:36 +0200 (CEST) Original-Received: from b0.ovh.net (HELO queueout) (213.186.33.50) by b0.ovh.net with SMTP; 27 Jul 2014 23:53:58 +0200 Original-Received: from 87-231-104-114.rev.numericable.fr (HELO ?192.168.4.10?) (py%luyten.fr@87.231.104.114) by ns0.ovh.net with SMTP; 27 Jul 2014 23:53:57 +0200 X-Mailer: Apple Mail (2.1878.2) X-Ovh-Tracer-Id: 8427642278055948300 X-Ovh-Remote: 87.231.104.114 (87-231-104-114.rev.numericable.fr) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: 0 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejfedrgeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeejfedrgeejucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecu X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Sun, 27 Jul 2014 20:20:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91860 Archived-At: --Apple-Mail=_B50E3582-5168-42E2-8472-F942B934B140 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 cua-rectangle feature does offer to type ? for help. It will display = several available key sequence. Since modifier is not known, a function = computes the string from the prefix variable. It is basically a switch, which works for =91hyper or =91super or =91alt = or =91meta , but it does not work for =91control. This is feasible to use =91control as the modifier.=20 (setq cua--rectangle-modifier-key =91control) This one liner patch fixes the help in such case. The cua-rect-help.patch is the result of `diff -c` command. The 0001- prefixed patch is git, but I believe this is not the proper = format. --Apple-Mail=_B50E3582-5168-42E2-8472-F942B934B140 Content-Disposition: attachment; filename=cua-rect-help.patch Content-Type: application/octet-stream; name="cua-rect-help.patch" Content-Transfer-Encoding: 7bit *** lisp/emulation/cua-rect.el.orig 2014-07-27 23:45:04.000000000 +0200 --- lisp/emulation/cua-rect.el 2014-07-27 23:44:56.000000000 +0200 *************** *** 1346,1351 **** --- 1346,1352 ---- (let ((M (cond ((eq cua--rectangle-modifier-key 'hyper) " H-") ((eq cua--rectangle-modifier-key 'super) " s-") ((eq cua--rectangle-modifier-key 'alt) " A-") + ((eq cua--rectangle-modifier-key 'control) " C-") (t " M-")))) (message (concat (if help "C-?:help" "") --Apple-Mail=_B50E3582-5168-42E2-8472-F942B934B140 Content-Disposition: attachment; filename=0001-cua-rect-help-check-for-control-value.patch Content-Type: application/octet-stream; name="0001-cua-rect-help-check-for-control-value.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e005034f22b87c5479e36649da416f7d74af1a72=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pierre-Yves=20Luyten=20=0ADate:=20= Sun,=2027=20Jul=202014=2020:04:50=20+0200=0ASubject:=20[PATCH]=20= cua-rect=20help=20:=20check=20for=20'control=20value=0A=0A---=0A=20= lisp/emulation/cua-rect.el=20|=201=20+=0A=201=20file=20changed,=201=20= insertion(+)=0A=0Adiff=20--git=20a/lisp/emulation/cua-rect.el=20= b/lisp/emulation/cua-rect.el=0Aindex=20d516bd4..2f9215b=20100644=0A---=20= a/lisp/emulation/cua-rect.el=0A+++=20b/lisp/emulation/cua-rect.el=0A@@=20= -1346,6=20+1346,7=20@@=20With=20prefix=20arg,=20indent=20to=20that=20= column."=0A=20=20=20(let=20((M=20(cond=20((eq=20= cua--rectangle-modifier-key=20'hyper)=20"=20H-")=0A=20=09=09=20((eq=20= cua--rectangle-modifier-key=20'super)=20"=20s-")=0A=20=09=09=20((eq=20= cua--rectangle-modifier-key=20'alt)=20"=20A-")=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20((eq=20cua--rectangle-modifier-key=20= 'control)=20"=20C-")=0A=20=09=09=20(t=20"=20M-"))))=0A=20=20=20=20=20= (message=0A=20=20=20=20=20=20(concat=20(if=20help=20"C-?:help"=20"")=0A= --=20=0A1.8.5.2=20(Apple=20Git-48)=0A=0A= --Apple-Mail=_B50E3582-5168-42E2-8472-F942B934B140--