all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Eli Zaretskii" <eliz@is.elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5
Date: Sat, 04 Jan 2003 13:07:28 +0300	[thread overview]
Message-ID: <2950-Sat04Jan2003130727+0200-eliz@is.elta.co.il> (raw)
In-Reply-To: <3E15B803.8080507@hekimian.com> (message from Joe Buehler on Fri, 03 Jan 2003 11:19:15 -0500)

> Date: Fri, 03 Jan 2003 11:19:15 -0500
> From: Joe Buehler <jbuehler@hekimian.com>
> 
> The problem is that _P is defined in the cygwin header files in a manner
> that is incompatible with its usage above.  It is one of a set of macros
> used in code that classifies characters as white space, printable, etc.:

Ouch!  This IMHO warrants a bug report to Cygwin maintainers.

> The above usage in pop.c does not seem correct to me -- aren't symbols
> beginning with _ supposed to be reserved for the compilation system, to avoid
> conflicts such as this one?

That's true, except that _P is used in many libraries' header files to
allow prototypes in ANSI compilers without breaking non-ANSI ones.

Okay, if this is the case, please make the #undef _P thing conditioned
on Cygwin.  That would at least limit the effect of the change to the
Cygwin build.  I'd also suggest a comment there explaining why is this
done, which mentions the use of _P in ctype.h macros.

      parent reply	other threads:[~2003-01-04 10:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-06 18:36 [PATCHES] 21.3.50 for Cygwin: patch 5 Joe Buehler
2002-12-25  6:12 ` Eli Zaretskii
2002-12-26 13:15   ` Juanma Barranquero
2002-12-26 23:39     ` Richard Stallman
2002-12-27  7:46       ` Juanma Barranquero
2002-12-28 21:22         ` Richard Stallman
2003-01-03 16:19   ` Joe Buehler
2003-01-04  4:19     ` Richard Stallman
2003-01-05  0:31       ` Kim F. Storm
2003-01-05 16:45         ` Benjamin Riefenstahl
2003-01-06  0:13           ` Kim F. Storm
2003-01-06 13:45             ` Joe Buehler
2003-01-06 17:13             ` Richard Stallman
2003-01-07  9:47               ` Kim F. Storm
2003-01-07 18:44                 ` Richard Stallman
2003-01-08 23:52                   ` Kim F. Storm
2003-01-09 23:14                     ` Richard Stallman
2003-01-10  9:49                       ` Kim F. Storm
2003-01-10 19:44                         ` Eli Zaretskii
2003-01-11  0:02                           ` Kim F. Storm
2003-01-12 11:55                           ` Richard Stallman
2003-01-11  0:22                         ` Richard Stallman
2003-01-05 18:34         ` [PATCHES] " Richard Stallman
2003-01-04 10:07     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2950-Sat04Jan2003130727+0200-eliz@is.elta.co.il \
    --to=eliz@is.elta.co.il \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.