From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Newsgroups: gmane.emacs.bugs Subject: bug#5950: defvaralias after defvar should be warned in runtime Date: Fri, 3 Aug 2018 17:00:33 -0400 Message-ID: <294c0e22-7741-d1ff-bdbf-f1f96cf112a7@gmail.com> References: <4BC6A096.8030801@yahoo.co.jp> <87r5gu34ag.wl%irieshinsuke@yahoo.co.jp> <3keicu1h3v.fsf@fencepost.gnu.org> <874liufjfj.fsf@gmail.com> <871sdyezwl.fsf@gmail.com> <87vaaoxm1z.fsf@gmail.com> <8e11e15a-a806-777e-1b18-3db9000c77de@gmail.com> <775d0859-cb89-3f35-0455-1357461128d0@gmail.com> <926a0bc8-e1c2-91bc-3a88-a16fd149f79b@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1533329948 25827 195.159.176.226 (3 Aug 2018 20:59:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 20:59:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: IRIE Shinsuke , 5950@debbugs.gnu.org, Stefan Monnier To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 03 22:59:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flhA8-0006bl-0W for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Aug 2018 22:59:04 +0200 Original-Received: from localhost ([::1]:53055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flhCE-0001Jp-Fa for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Aug 2018 17:01:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flhC7-0001J6-QA for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 17:01:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flhC2-0001ea-W9 for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 17:01:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flhC2-0001eU-Rw for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 17:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flhC2-0004Ve-JZ for bug-gnu-emacs@gnu.org; Fri, 03 Aug 2018 17:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Aug 2018 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 5950-submit@debbugs.gnu.org id=B5950.153333004217296 (code B ref 5950); Fri, 03 Aug 2018 21:01:02 +0000 Original-Received: (at 5950) by debbugs.gnu.org; 3 Aug 2018 21:00:42 +0000 Original-Received: from localhost ([127.0.0.1]:40242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flhBh-0004Ut-Vq for submit@debbugs.gnu.org; Fri, 03 Aug 2018 17:00:42 -0400 Original-Received: from mail-qk0-f182.google.com ([209.85.220.182]:44167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flhBg-0004Ue-Gw for 5950@debbugs.gnu.org; Fri, 03 Aug 2018 17:00:40 -0400 Original-Received: by mail-qk0-f182.google.com with SMTP id v17-v6so4969337qkb.11 for <5950@debbugs.gnu.org>; Fri, 03 Aug 2018 14:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=adjEX7PsOZa67V9/bNeFMvL4t1Vi/1qyF3/4JwQ+Fww=; b=uzkWXFuUi4kTot5zd0AUJTGBOPVM6yJy/GEUcWX2RYweI0oblq8LSe7pzUq2zQIUcJ qvqbktKsHZPgqzbexaHXevVFfmoUEbVAAC8B6kE3v8qWJN0fd0D89KpO1ZBPhAJAUS3F ue/Yfm89ACz4uuxxc3eK6qKKmo7AsoUrrjJz35a+0aHoNIc4JPuu2D4IPDsiYPlgTEal F/DfTwqJIQbAntHdW/jlwvIkg/nozOJLt9KdgnixKjoPtODBeE+eifqPcR3NUhdN6ugU /DMoI0hKNQchkKzIMRR6AI7bTFAA5cegQQzgGOO7PbGT6jPVTsv6BLhQm+pQhPsaWJj3 QiBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=adjEX7PsOZa67V9/bNeFMvL4t1Vi/1qyF3/4JwQ+Fww=; b=DN5kxRrNtoXqRsgO+TYHru/YWK2WVxBh7f4l5R4p9t/zCLdt+P/V5d1G9z+v7rRaSM ChVKnstWaWBWPsS6ViDyQLygJqZIqpyS0p5WhYE6AamSQK8W8aFiqVwK66joGgvd02MS 6DqcS4UucyWDGR/p1qcfqFx13ItPOwS2LKF1lXrGgR2oa/D6mGn3N1JNVP8qnzEp+Ob1 TdD/HngB/lqgOLrPUufM6qkEdbwoSGCErG5TD3kBoDS1aT+ME18gdIbUji15vGt4C2vp gfI3YvYtJAvvmBAO8r51x2qO536PPOKfRWLWDi0WJqdwFw6spe9mTuAwm8ZRyoEXBk7I qgdw== X-Gm-Message-State: AOUpUlGhz6QsToVgsmptJb7+RDd1vmR4ruN0KTBnAwqr3CM4QWPLjmNz USJYuzmIhVkCtW+Qb2gCYV7BW3JQ X-Google-Smtp-Source: AAOMgpcZMn517RQuJBmoDL4mI6nkTl4dN9y7tPJ2nZEKgHtEurs0apglpuToyyraJiNLlcPsA5fHqg== X-Received: by 2002:a37:50c3:: with SMTP id e186-v6mr5067589qkb.91.1533330034911; Fri, 03 Aug 2018 14:00:34 -0700 (PDT) Original-Received: from [18.26.2.123] (26-2-123.dynamic.csail.mit.edu. [18.26.2.123]) by smtp.gmail.com with ESMTPSA id z18-v6sm5168152qtz.89.2018.08.03.14.00.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Aug 2018 14:00:34 -0700 (PDT) In-Reply-To: Content-Language: en-GB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149247 Archived-At: On 2018-08-03 16:23, Noam Postavsky wrote: > On 2 August 2018 at 23:33, Clément Pit-Claudel wrote: >> On 2018-08-02 13:03, Stefan Monnier wrote: >>>>> The typical failure case goes like this, user does this: >>>>> >>>>> (setq the-package-setting 'foo) >>>>> (require 'the-package) >>>>> >>>>> And the-package.el does this: >>>>> >>>>> (defvar the-package-real-setting 'bar) >>>>> ;; Oops! User's setting of `foo' is overwritten here: >>>>> (defvaralias 'the-package-setting 'the-package-real-setting) >>>> >>>> Thanks. Should the warning be disabled when both variables are >>>> already `defvar'd, then? >>> >>> Why? Replace `setq` with `defvar` in the above scenario and you have >>> the same problem. >> >> Do you? I thought the problem was that you were overwriting a user setting… if you change the first setq into a defvar, where's the user setting that you're overwriting? > > If the user writes defvar instead of setq, it has the exact same > effect: they've set the-package-setting to foo, which will be > overwritten to bar, same as before. Right, I understand that. But why would a user write 'defvar' to set a user variable? I guess I'm just a bit confused by the warning. What's the proper way to resolve it? Should I create the alias before loading flycheck?