From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#7019: 23.2; [PATCH] fix bugs in diary/appt Date: Mon, 13 Sep 2010 20:26:03 -0400 Message-ID: <2939td5fxg.fsf@fencepost.gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1284424850 16051 80.91.229.12 (14 Sep 2010 00:40:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 14 Sep 2010 00:40:50 +0000 (UTC) Cc: 7019@debbugs.gnu.org To: Leo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 14 02:40:49 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OvJZm-0007gm-0D for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Sep 2010 02:40:46 +0200 Original-Received: from localhost ([127.0.0.1]:49960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvJZl-0001Mc-CD for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Sep 2010 20:40:45 -0400 Original-Received: from [140.186.70.92] (port=58752 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvJZa-0001L5-HB for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2010 20:40:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvJZV-0005XW-G6 for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2010 20:40:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54859) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvJZV-0005XS-Ag for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2010 20:40:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OvJJa-00005H-F3; Mon, 13 Sep 2010 20:24:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Sep 2010 00:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7019-submit@debbugs.gnu.org id=B7019.1284423821317 (code B ref 7019); Tue, 14 Sep 2010 00:24:02 +0000 Original-Received: (at 7019) by debbugs.gnu.org; 14 Sep 2010 00:23:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvJJE-000053-MF for submit@debbugs.gnu.org; Mon, 13 Sep 2010 20:23:40 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvJJC-00004x-7X for 7019@debbugs.gnu.org; Mon, 13 Sep 2010 20:23:38 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OvJLX-00084k-Oz; Mon, 13 Sep 2010 20:26:03 -0400 X-Spook: JPL rs9512c Consul Rule Psix Blowfish Centro undercover X-Ran: f&in2c2InA`2Y[82;*jUW2{Ze[^W#$+:MK;5;\#$4/K*yhCKE)vScIGN,LD&cDoveu=oYg X-Hue: green X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 13 Sep 2010 20:24:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40148 Archived-At: Leo wrote: > The doc string of diary-list-entries says the return list is sorted, Where does it say that? Oh, I guess you might mean: Returns a list of all relevant diary entries found, if any, in order by date. Which is true unless include files are involved. Note it does not mean that entries are also sorted by time of day. I don't think sorting by default is the right solution. I might just mention in the docs that if include files are used, the order will day order for the entries from any given file, then by the order in which the include files were processed. Some people might want it that way (eg not sorted by time of day), and those who don't are probably aready using diary-sort-entries. The fact that the entries are in day order is really just a consequence of how the code is implemented, rather than a deliberate choice. > (add-hook 'diary-list-entries-hook 'diary-sort-entries) is not > guaranteed to work unless that is the very last function to run. OK, I think that should just be pointed out in the docs. (The manual sort of does this without being explicit.) > appt-make-list replies on sorted diary entries to work. Looks like it relies on them being sorted in _day_ order, but not in _time_ order within any given day. Again, this is true unless include files are involved. I guess this is why nobody noticed till now. I'll fix that somehow.