From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/compat 6a60af22da: Optimize string-search Date: Fri, 11 Aug 2023 09:12:13 +0200 Message-ID: <2904fc15-9d4b-448f-08c7-5d438e3f79ff@daniel-mendler.de> References: <169158945793.6388.8459711282582712176@vcs2.savannah.gnu.org> <20230809135738.457BDC038BF@vcs2.savannah.gnu.org> <87jzu2jemz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9759"; mail-complaints-to="usenet@ciao.gmane.io" To: Philip Kaludercic , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 11 09:13:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUML4-0002Mx-9U for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Aug 2023 09:13:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUMKA-00072s-DG; Fri, 11 Aug 2023 03:12:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUMK5-00072Y-Ss for emacs-devel@gnu.org; Fri, 11 Aug 2023 03:12:37 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUMK3-0000nO-Rf for emacs-devel@gnu.org; Fri, 11 Aug 2023 03:12:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1PvEDoHuqRpgNFaaT6Da50BkxQA3kehIbspD6Cxrd3s=; b=bik5TuORprWXmQxGKu7bImPXya KmyQdsBARnUggF8+0lThnC5YSf9RwvLePk1F3TgBCvO/oRhmpUKxoWTmPi9c/VsvonUYV7kA6lq3O UZO4j8HYhiO7vg3WyJnesDAX7D+M9gqA+HDZmaxFZl3Q/7tMqNxAKVTPfcJnxqrHeZRE=; Content-Language: en-US In-Reply-To: <87jzu2jemz.fsf@posteo.net> Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308559 Archived-At: On 8/11/23 08:07, Philip Kaludercic wrote: > ELPA Syncer writes: > >> branch: externals/compat >> commit 6a60af22da1f1a7b08457a4016b9412a475afe4a >> Author: Daniel Mendler >> Commit: Daniel Mendler >> >> Optimize string-search >> --- >> compat-28.el | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/compat-28.el b/compat-28.el >> index fe69315522..b305ab2fff 100644 >> --- a/compat-28.el >> +++ b/compat-28.el >> @@ -52,9 +52,8 @@ issues are inherited." >> (when (and start-pos (or (< (length haystack) start-pos) >> (< start-pos 0))) >> (signal 'args-out-of-range (list start-pos))) >> - (save-match-data >> - (let ((case-fold-search nil)) >> - (string-match (regexp-quote needle) haystack start-pos)))) >> + (let (case-fold-search) >> + (string-match-p (regexp-quote needle) haystack start-pos))) >> >> (compat-defun length= (sequence length) ;; [[compat-tests:length=]] >> "Returns non-nil if SEQUENCE has a length equal to LENGTH." > > I don't believe this is a legal optimisation, even if the regular > expression is quoted. Consider Hi Philip, did you notice that I replaced `string-match' with `string-match-p'? Daniel