From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Tue, 1 Oct 2024 04:57:19 +0300 Message-ID: <28d77c12-8426-43bc-9833-f07b391cbe05@yandex.ru> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> <87y13dfgzz.fsf@melete.silentflame.com> <5e956e3b-5891-401a-a898-e339f52ea307@yandex.ru> <87h69ydnvd.fsf@melete.silentflame.com> <878qv9scps.fsf@melete.silentflame.com> <12b28146-5cbc-48cd-b0e2-0c528d4b9b1c@yandex.ru> <87ikudqocz.fsf@melete.silentflame.com> <9be40a05-3260-40a8-9c35-c5daac413844@yandex.ru> <87wmisprfk.fsf@melete.silentflame.com> <16230560-cad5-4cc9-a272-a0f961247158@yandex.ru> <87h69wppm5.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23857"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 01 03:58:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svSA2-000646-V8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Oct 2024 03:58:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svS9p-0007fn-Nc; Mon, 30 Sep 2024 21:58:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svS9n-0007fB-3x for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:58:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svS9m-0002Vz-49 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=r0bV/Q87NQy3Rkd5DcQOWNfkUgMQ4iKt4k8eOqf20Yw=; b=LRSsKInyg4wNUWCBtzuu2USRrM1aGqI/PiQZdHQrUMm0bLUvnVEPRpg1jm07BVS49fHlrOd9nHZoeCh31U2YBdw2aUu4jKdlmFdB7pi1ZwKNh4fljOH8mcdXvaD5uOMfV8FV/baAWT19EbU8tQ3rSuMieA9R9dqdF3FSDSNfM+7OdWXzIWyHRy3X3HgecbW0BZirEdS8cO0mjDEWIirAgUgqufg2zRN0UsykybanhYSm7rP5SznU69rpYcnoF+jU8htJTVAxy66T9YmF01PDtSO4L8JpyU6Wzg3e+unYOxim28+XaT+7c37QbM5af3wtycpOWw9FF0ZLKo2JUrq1rA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svSAJ-0003Vz-Fj for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 21:59:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2024 01:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.172774791613326 (code B ref 73387); Tue, 01 Oct 2024 01:59:03 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 1 Oct 2024 01:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:48403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svS9r-0003Sq-GX for submit@debbugs.gnu.org; Mon, 30 Sep 2024 21:58:35 -0400 Original-Received: from forward501d.mail.yandex.net ([178.154.239.209]:45358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svS9o-0003SK-Ey for 73387@debbugs.gnu.org; Mon, 30 Sep 2024 21:58:34 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-38.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-38.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:5486:0:640:376b:0]) by forward501d.mail.yandex.net (Yandex) with ESMTPS id 2C97860F1F; Tue, 1 Oct 2024 04:57:26 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-38.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id MvOxYJ1AaW20-oFjFclQP; Tue, 01 Oct 2024 04:57:25 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1727747845; bh=r0bV/Q87NQy3Rkd5DcQOWNfkUgMQ4iKt4k8eOqf20Yw=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=M0WqSzLWd48VLqmN7MpMcP9PChn255TUYQRu0kgqwGIJqaOles3XARQdttu8jUpMD MpsPohPfnA+vQjzv3xnGd09d7r0WFEs5W2ExenZsNDEciWEPkXw627y1B8Snz6ek4a cOehCnckl8p0a+7wolidHkhiThdjD+0R5mSTX5VQ= Authentication-Results: mail-nwsmtp-smtp-production-main-38.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 5451E1200043; Mon, 30 Sep 2024 21:57:22 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 30 Sep 2024 21:57:22 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdduiedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrd hruheqnecuggftrfgrthhtvghrnhepiefhjeeuveetffffvdefteffffekhfeuudejieeh heeiudelgfehgffffeduffdunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqddufeeffeelleehhedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvg igrdhruhesfhgrshhtmhgrihhlrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgep shhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrd hnrghmvgdprhgtphhtthhopeejfeefkeejseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepmhhonh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 30 Sep 2024 21:57:20 -0400 (EDT) Content-Language: en-US In-Reply-To: <87h69wppm5.fsf@melete.silentflame.com> X-Yandex-Filter: 1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292757 Archived-At: On 01/10/2024 04:40, Sean Whitton wrote: > Is it right that diff-vc-deduce-fileset will only ever be called in the > context of using C-x v v to commit a patch? The name of the function > suggests that it might be used for something else, if not now then in > the future. It's not a 100% guarantee but for now that's how things stand, and it doesn't work in a narrowed buffer. So for simplicity's sake we can make it show an error with such instructions, I think. I don't mind doing it the another way too, but if its return value is not used, that's not a very intuitive design.