From: martin rudalics <rudalics@gmx.at>
To: Alan Third <alan@idiocy.org>,
48162@debbugs.gnu.org, pankaj@codeisgreat.org
Subject: bug#48162: 28.0.50; Resizing using set-frame-width doesn't expand mode-line
Date: Sun, 2 May 2021 18:57:08 +0200 [thread overview]
Message-ID: <28c3ab57-5735-58fb-8008-dbb1b57c88f6@gmx.at> (raw)
In-Reply-To: <YI7XJcMpgw80RjiM@idiocy.org>
> This patch reintroduces the infinite loop I was trying to avoid.
>
> viewDidResize is called every time the view's "frame" is touched. Most
> of the time this happens when nothing has changed, but calling
> change_frame_size, even when nothing has changed, appears to cause the
> toolbar to redraw, which causes viewDidResize to be called again, and
> so on ad infinitum.
>
> So I put in the check whether the new frame size that's reported is
> actually the same as the previous frame size, and if so do nothing.
> Then realised that I need to check the new_height and new_width
> settings in case the change is already pending.
>
> I'm not sure where new_size_p comes into it, perhaps we don't even
> need to check it in viewDidResize, because all we care about is the
> final outcome?
>
> Maybe this really isn't the way to do it and I need to keep track of
> the frame size separately, which is something I was hoping to avoid.
new_size_p true means that Emacs has already received a resize event for
this frame but was not yet able to process it. So the additional
|| (newh == emacsframe->new_height
&& neww == emacsframe->new_width)))
in that case should "do nothing" when "nothing has changed". Where does
my reasoning go wrong?
martin
next prev parent reply other threads:[~2021-05-02 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 15:42 bug#48162: 28.0.50; Resizing using set-frame-width doesn't expand mode-line Pankaj Jangid
2021-05-02 16:12 ` martin rudalics
2021-05-02 16:45 ` Alan Third
2021-05-02 16:57 ` martin rudalics [this message]
2021-05-02 17:18 ` Alan Third
2021-05-02 19:19 ` martin rudalics
2021-05-02 21:49 ` Alan Third
2021-05-03 3:40 ` Pankaj Jangid
2021-05-03 12:50 ` Alan Third
2021-05-03 7:49 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28c3ab57-5735-58fb-8008-dbb1b57c88f6@gmx.at \
--to=rudalics@gmx.at \
--cc=48162@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=pankaj@codeisgreat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.