From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Date: Wed, 5 Jun 2024 18:52:15 -0700 Message-ID: <28afde26-8d83-8b5f-b617-a2797ea5e1fc@gmail.com> References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@gmail.com> <868qzq1n3r.fsf@mail.linkov.net> <86frtvrgtn.fsf@mail.linkov.net> <52b77c3b-f556-b436-c8c5-1f157681fa53@gmail.com> <86o78i4j8u.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71284@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 04:00:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF2QJ-0000eJ-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 04:00:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF2Pu-0004uf-ON; Wed, 05 Jun 2024 21:59:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF2Pt-0004uX-6r for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 21:59:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF2Ps-0005Eq-Vs for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 21:59:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF2Q6-00074T-PX for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 22:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71284-submit@debbugs.gnu.org id=B71284.171763919127126 (code B ref 71284); Thu, 06 Jun 2024 02:00:02 +0000 Original-Received: (at 71284) by debbugs.gnu.org; 6 Jun 2024 01:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:56440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF2Pu-00073Q-KB for submit@debbugs.gnu.org; Wed, 05 Jun 2024 21:59:51 -0400 Original-Received: from mail-yw1-f176.google.com ([209.85.128.176]:51667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF2Ps-000738-Bo for 71284@debbugs.gnu.org; Wed, 05 Jun 2024 21:59:49 -0400 Original-Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-627f3265898so4117297b3.3 for <71284@debbugs.gnu.org>; Wed, 05 Jun 2024 18:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717639108; x=1718243908; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=djK4hG6LKK/oyHicD5sc+cfJ0JRgOTjFJtj9KHqBYRI=; b=iWOVAA6MEAZkanv2pXd3jJoiH7bc68yZhCfyFTL7oIL4mfk2vYHuApwTwt2WZh0U4k z5EBHRBMwSb8sqpjju51TITRp1vfORqeHpTwWMrtQAPJJaTA36cgTNNL14eJcrpZ/PHn M/8nL6bLUCGofMnIiaqciMNopEIVj05vuyMFudwCCFUCpLegR1yF1OE9/hRTARS3T2Wu 6AuvfyUHNseN/UJPdXjnzjwyqHpOryTHOFMMnv7LF5qtE9zfealHmfWJV8LcK7rXu91V exiEmAFKO6hKny9Gg137nuvzL6kD+8x8X13Mm9LsqkVyu7mboGTBM6hECQ+Z+QumWRpn p+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717639108; x=1718243908; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=djK4hG6LKK/oyHicD5sc+cfJ0JRgOTjFJtj9KHqBYRI=; b=Xv//el2Kbd/DQ54zZgp4VZWNa+DMbmTa320njo3gdedSP/Fc4TdzeYjzhrmIapiqqf 0rPkmWu1AFHYCSxdauGrX7rzwrmvH4AeCTu6uA7H8pJQHIRkA5OTiPEFWRQQrRJQ77pz VguNkpgQ3QeYUV+ZNeoWKUDT9EVMcc1rdkOpQ+1aLSn870i2h2I6kZ2p3xcqvGhLL/4K fPhJKp7bDYhB/i90TpMpHQj5uPZXi2/IJ+2EIjr10431i4gsD4Vf5Ud+cW4lgubNFesq hkLJXFFJTb2D/0nMKeUB9iomD3h6at4vtEHTt8toXCBzfQRBR4RXpBOQQ7zcpUr16s8K AhSA== X-Gm-Message-State: AOJu0Yz1hS0xJXlvVqeXCnDf0/LHxVXEZkXPoX9LAzKduV6JpeeEvf3P kyVxsCkwPl1tTW6WA9wJM7B/sjWHRQ4gP93En/jfFieu2bb8imjMSKbWYQ== X-Google-Smtp-Source: AGHT+IFvswOcLQrwAzAoNV4ndW+qIWnWeTPCYaiqCjbJLZZSbXK0cSfbHBbrynWKV9STB2Qj4pGCPw== X-Received: by 2002:a17:902:ea06:b0:1f3:39f8:7e7f with SMTP id d9443c01a7336-1f6a59ffe74mr48379945ad.14.1717638736690; Wed, 05 Jun 2024 18:52:16 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f6bd7cd297sm2139005ad.165.2024.06.05.18.52.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 18:52:16 -0700 (PDT) Content-Language: en-US In-Reply-To: <86o78i4j8u.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286645 Archived-At: On 6/2/2024 11:45 PM, Juri Linkov wrote: >> In any case, the more I think about this, the more my current patch seems >> like the wrong way to go about this. Even just describing the user-facing >> behavior in all scenarios is pretty complex, so I think it might be better >> to keep it simple and have a single outline level. >> >> That said, for the multi-line prompt case, I wonder if it would make sense >> for outline.el to support multi-line headers. If I could mark the entire >> prompt + command input as a "header", then collapsing it would look better: >> users would still see all of their input in the collapsed node. > > The multi-line headers have such disadvantage that the outlines > are not compact anymore. Also multi-line headers might have > more technial issues with displaying an ellipsis at the end. Given that you mentioned a few other cases where multi-line headers might be nice (assuming the number of lines is small), maybe it would make sense to see what an implementation of that looks like. I'll see about writing a patch for this. (Another interesting thing I might try is to see if we could provide some custom single-line abbreviation for multi-line headers. That would let us have compact headers when they're collapsed, even if the "header" part is really multiple lines when expanded.)