From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Greg Minshall Newsgroups: gmane.emacs.devel Subject: Re: make check fails? (emacs-26.1 w/modules) Date: Fri, 07 Sep 2018 12:10:45 +0300 Message-ID: <28975.1536311445@minshall-apollo.minshall.org> References: <01b1788d-b97f-2b3d-574c-d9e441acf9ad@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Trace: blaine.gmane.org 1536311388 19020 195.159.176.226 (7 Sep 2018 09:09:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2018 09:09:48 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 11:09:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fyClr-0004qE-V4 for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2018 11:09:44 +0200 Original-Received: from localhost ([::1]:37540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyCny-0008J2-8e for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2018 05:11:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyCmz-0008IB-OR for emacs-devel@gnu.org; Fri, 07 Sep 2018 05:10:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyCmz-0005yy-45 for emacs-devel@gnu.org; Fri, 07 Sep 2018 05:10:53 -0400 Original-Received: from hiwela.pair.com ([209.68.5.201]:13898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fyCmu-0005u4-Pk; Fri, 07 Sep 2018 05:10:48 -0400 Original-Received: from hiwela.pair.com (localhost [127.0.0.1]) by hiwela.pair.com (Postfix) with ESMTP id A683A980512; Fri, 7 Sep 2018 05:10:47 -0400 (EDT) Original-Received: from minshall-entroware-apollo.cliq.com (unknown [5.24.70.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hiwela.pair.com (Postfix) with ESMTPSA id 570EB8F082E; Fri, 7 Sep 2018 05:10:47 -0400 (EDT) Original-Received: from minshall-apollo.minshall.org (localhost [127.0.0.1]) by minshall-entroware-apollo.cliq.com (Postfix) with ESMTP id 306F76C002D; Fri, 7 Sep 2018 12:10:45 +0300 (+03) In-reply-to: Your message of "Wed, 05 Sep 2018 13:55:45 -0700." <01b1788d-b97f-2b3d-574c-d9e441acf9ad@cs.ucla.edu> X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 26.1 Content-ID: <28974.1536311445.1@minshall-apollo.minshall.org> X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 209.68.5.201 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229386 Archived-At: here's a possibility, but i don't really understand the plumbing. i wonder if it's the case that in src/emacs-module.c, the member "pending_non_local_exit" of "struct emacs_env_private" should be marked "volatile". my sense is that it is, among other things, what links the lower (signal/interrupt context) and upper (thread context) halves of emacs/emacs-module (though i can't really see it). if so, probably also the members "non_local_exit_{symbol,data}" should be similarly marked. [marking pending_non_local_exit volatile *does* result in (what appears to be) good optimization; this is hardly surprising, though, as probably if the optimizer saw even "volatile int i;" as a member of the struct, it would back way off any code around it. if this is what is causing the bad optimization, it seems likely to still be a compiler.] cheers, Greg ps -- it's been years, decades, since i've had occasion to think of "volatile", and possiblly the technology of such "attributes" has advanced in the meantime.