From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12149: 24.1; `C-h f' is worse and worse at telling where a function was defined Date: Mon, 6 Aug 2012 10:49:15 -0700 Message-ID: <28819A29BB374779AEEA60B7FF63A25B@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344275419 19093 80.91.229.3 (6 Aug 2012 17:50:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2012 17:50:19 +0000 (UTC) To: 12149@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 06 19:50:17 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyRRY-0001Bz-Al for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2012 19:50:16 +0200 Original-Received: from localhost ([::1]:40473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRRX-0006KX-I8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2012 13:50:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRRU-0006Fg-Ag for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyRRQ-00089E-Lt for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:50:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRRQ-00088r-IL for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:50:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SyRZ3-0003MO-Tn for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Aug 2012 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.134427584112859 (code B ref -1); Mon, 06 Aug 2012 17:58:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Aug 2012 17:57:21 +0000 Original-Received: from localhost ([127.0.0.1]:37885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyRYP-0003LM-4g for submit@debbugs.gnu.org; Mon, 06 Aug 2012 13:57:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44826) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SyRYM-0003LE-9m for submit@debbugs.gnu.org; Mon, 06 Aug 2012 13:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyRQh-0007mh-JH for submit@debbugs.gnu.org; Mon, 06 Aug 2012 13:49:24 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:48858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRQh-0007md-GE for submit@debbugs.gnu.org; Mon, 06 Aug 2012 13:49:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRQg-0005Yo-GC for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:49:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyRQf-0007mE-DR for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:49:22 -0400 Original-Received: from acsinet15.oracle.com ([141.146.126.227]:49514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyRQf-0007lz-79 for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2012 13:49:21 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q76HnHjl030088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Aug 2012 17:49:18 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q76HnGkK000512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 6 Aug 2012 17:49:17 GMT Original-Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q76HnGbP032571 for ; Mon, 6 Aug 2012 12:49:16 -0500 Original-Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 06 Aug 2012 10:49:16 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac1z+8ugNDNInFAtRSmcSpG68Rcx4A== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62879 Archived-At: I have this code: (defun 1on1-setup-minibuffer-frame-coloring () "Redefine some built-in functions so they color the minibuffer frame. Functions redefined: `y-or-n-p', `top-level', `abort-recursive-exit'." (or (fboundp '1on1-ORIG-y-or-n-p) (fset '1on1-ORIG-y-or-n-p (symbol-function 'y-or-n-p))) (defun y-or-n-p (prompt) "Ask user a \"y or n\" question. Return t if answer is \"y\". Takes one argument, which is the string to display to ask the question. It should end in a space; `y-or-n-p' adds `(y or n) ' to it. No confirmation of answer is requested; a single character is enough. Also accepts SPC to mean yes, or DEL to mean no." (if (> (minibuffer-depth) 0) (1on1-ORIG-y-or-n-p prompt) (1on1-color-minibuffer-frame-on-setup) (prog1 (1on1-ORIG-y-or-n-p prompt) (1on1-color-minibuffer-frame-on-exit)))) (or (fboundp '1on1-ORIG-top-level) (fset '1on1-ORIG-top-level (symbol-function 'top-level))) (defun top-level () "Exit all recursive editing levels." (interactive) (1on1-color-minibuffer-frame-on-exit) (1on1-ORIG-top-level)) ...) In Emacs prior to Emacs 23, `C-h f' did not point to the wrong files as having defined these function. At least it did not lie and steer you wrong. Emacs 23.4 did not point to the wrong file for `y-or-n-p', but it did point to the wrong file for `top-level'. Emacs 24.1 gets them both wrong. It simply gives the original location (from emacs -Q) for each of them: `C source code' for `top-level' and `subr.el' for `y-or-n-p'. This is not good. Better to say "no idea" than to mislead the user this way. Instead of improving locating function definitions, things have gotten worse. In GNU Emacs 24.1.1 (i386-mingw-nt5.1.2600) of 2012-06-10 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include'