From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: pdumper's performance Date: Tue, 4 Sep 2018 14:20:54 -0700 Message-ID: <282958d399469f8d3631f5bee14d857f.squirrel@dancol.org> References: <9e53f0129e556ee5ac27966124ebc4c0.squirrel@dancol.org> <3df201ad63aa584afecb227af8628e6c.squirrel@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1536095938 31197 195.159.176.226 (4 Sep 2018 21:18:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 21:18:58 +0000 (UTC) User-Agent: SquirrelMail/1.4.23 [SVN] Cc: Daniel Colascione , emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 04 23:18:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxIir-00080o-BB for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 23:18:53 +0200 Original-Received: from localhost ([::1]:52685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxIkx-0004nu-8y for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 17:21:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53736) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxIkr-0004no-Fc for emacs-devel@gnu.org; Tue, 04 Sep 2018 17:20:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxIkq-00033m-Is for emacs-devel@gnu.org; Tue, 04 Sep 2018 17:20:57 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:51420) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxIkq-00032N-3l for emacs-devel@gnu.org; Tue, 04 Sep 2018 17:20:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=gYSEad4xRtWbQPJVrlToo9DIQcI+DzPFszW7aG1jKns=; b=bFC/mwJZlVjxh6UKbN/n6xtSQlG0IRmjur4xAr5xeQl/6QwsUy7SIzPUewZdnCgRuBGJqdcdGeqgu2UVPF0szaoxH4ek9rXNx29Ef0kxVNrUCACHPvPRh/zahT5qTHMo9wiCVaDTpwrmQOXgDogk3c7nBHbycw5P0NVPANokl96Wn7TLXjvh22eJHhnJcmaBa3w9E/aFMe78+8Egqxe0CE2+K5vLk5A5h9RrPekbe6qHJGNnFUDw09rGiWwWmUgdNeg1Yo5PLjtk0+w2rLnYUQJeq6Qz/9cnBOer10b8i8uyhQ0eUxHNHC2vAFuLUY0GcBMIVzFDc07FT1HWfXtIfQ==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxIko-0007Oj-FT; Tue, 04 Sep 2018 14:20:54 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Tue, 4 Sep 2018 14:20:54 -0700 In-Reply-To: X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229270 Archived-At: >> Try it and see before deciding that there's a performance problem. > > Hm... there's a misunderstanding: the issue is not one of performance > problem, but of separation of concerns. Moving the markbits elsewhere > should be done in a separate patch (before or after the pdumper patch). There is no separation-of-concerns problem. The mark bit thing isn't some unrelated bonus feature of pdumper. It's how the dump image *works*. To make pdumper work differently, and worse, merely to create some kind of fictitious separation between its component parts strikes me as a bad idea and unnecessary work.