From: Ken Brown <kbrown@cornell.edu>
To: 30176@debbugs.gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#30176: readlinkat and _FORTIFY_SOURCE on Cygwin
Date: Fri, 19 Jan 2018 15:46:39 -0500 [thread overview]
Message-ID: <27a80447-e39b-0099-6063-1ab3517f668c@cornell.edu> (raw)
The next release of Cygwin (2.10.0), expected within the next few weeks,
is going to have a new implementation of _FORTIFY_SOURCE guards for many
functions, including readlinkat. The implementation is based on that of
NetBSD and has the effect of adding code that looks essentially as
follows after preprocessing:
ssize_t
__ssp_real_readlinkat (int __dirfd1, const char *__path,
char *__buf, size_t __len)
__asm__("readlinkat");
extern __inline__ __attribute__((__always_inline__, __gnu_inline__))
ssize_t
readlinkat (int __dirfd1, const char *__path, char *__buf,
size_t __len)
__asm__("__ssp_protected_readlinkat");
extern __inline__ __attribute__((__always_inline__, __gnu_inline__))
ssize_t
readlinkat (int __dirfd1, const char *__path, char *__buf,
size_t __len)
{
if (__builtin_object_size(__buf, 2 > 1) != (size_t)-1
&& __len > __builtin_object_size(__buf, 2 > 1))
__chk_fail();
return __ssp_real_readlinkat (__dirfd1, __path, __buf, __len);
}
The occurrence of this code in fileio.c, combined with the use of a
pointer to readlinkat in the definition of emacs_readlinkat, leads to an
"undefined reference to `__ssp_protected_readlinkat'" linking error.
I'd appreciate some advice on how to fix this. I can think of three
possibilities, but maybe there's something better:
1. Add "#define _FORTIFY_SOURCE 0' at the top of fileio.c (Cygwin only).
2. Pretend like Cygwin doesn't have readlinkat. Then gnulib will create
its own definition, which will be found by the linker in libegnu.a.
3. Ask gnulib to come up with a fix.
Thanks in advance for any advice.
Ken
next reply other threads:[~2018-01-19 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 20:46 Ken Brown [this message]
2018-01-19 23:25 ` bug#30176: readlinkat and _FORTIFY_SOURCE on Cygwin Paul Eggert
2018-01-20 12:30 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27a80447-e39b-0099-6063-1ab3517f668c@cornell.edu \
--to=kbrown@cornell.edu \
--cc=30176@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.