From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Mon, 21 Aug 2023 11:51:36 -0300 Message-ID: <27a78233-5758-c03e-e3a2-342d194d1448@gmail.com> References: <8ca48b5a-1619-8da8-ae3a-6ae96351a19d@gmail.com> <87v8eelh2s.fsf@gmx.net> <87r0p2l5pp.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7720"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: 64046@debbugs.gnu.org To: Ola x Nilsson , Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 21 16:52:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qY6GT-0001pJ-48 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Aug 2023 16:52:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY6G9-00070G-Oe; Mon, 21 Aug 2023 10:52:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY6G8-000706-Bd for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 10:52:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY6G8-0001a1-3V for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 10:52:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY6GA-0001d5-B3 for bug-gnu-emacs@gnu.org; Mon, 21 Aug 2023 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Aug 2023 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16926295096230 (code B ref 64046); Mon, 21 Aug 2023 14:52:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 21 Aug 2023 14:51:49 +0000 Original-Received: from localhost ([127.0.0.1]:57471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Fw-0001cQ-Op for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:51:49 -0400 Original-Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]:53563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY6Fv-0001c4-01 for 64046@debbugs.gnu.org; Mon, 21 Aug 2023 10:51:47 -0400 Original-Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-56d8bc0d909so2218853eaf.3 for <64046@debbugs.gnu.org>; Mon, 21 Aug 2023 07:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692629499; x=1693234299; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Dwpx7GYUU60sOSkdV3+JcPbUYHgbcWOuQwfAfFXw1w=; b=TlYOuzViRf5fWh254YdavPoyUrJOc04jEV79d8ptrAysyANzZjfAKEsRptEY6PTYUY gsKw2L5O2h1B6JYlho3AodRzIzjDLdK8EwcL++2rUUb+hswg1gvzDeLKWI5Qv2M6k267 o/o27GnluX1uTDT37EEgiKV6T9Def5iyiFSBdKZkMefOZA+K/Nk8IJfPbwZm3/cG0m+Y UvZHfi6VMM5JPqjazhN7vU4Ys+ZrZzndsAQf/8sGz90cCPIumS7ar9TKDpIWaAPyWldZ oV9pAka7FkLc6fAVgn5C55v4DiaJrQ9uGoeZ0BFt0d3Rk7cJR6i8aXqTAxfPB58x3Uwl c1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692629499; x=1693234299; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Dwpx7GYUU60sOSkdV3+JcPbUYHgbcWOuQwfAfFXw1w=; b=h7p7b52EK23hU2MWS+aol/wjfnJB36IP7naHEQPxAIn8d7ZybJywqBfmHExu4dabHw lWhQYKgfDVmO4M44vEenYrHCch0W1s9m96wrCVX4UcLq2LZkVJZMPOV8KpLPYBXDud7y kIKKc4ncZXMV7UasG5sLGlb85tX2KSmw2WqjSHovTQQyyy6Xuo5I56Yj7bpHZuFDooZf O3im1RMcssRVsLlEeuiozluSZBK0WaRPcDjz3CSgGNXMd8pH0zZmLRMAULGcsx3YzVYx bTUKiUcGn4POLSTLD/MacsqKTMWIadHdeGWwRBLMleqrwOtm49Lh68JNnStWSm31AJG7 5r0A== X-Gm-Message-State: AOJu0YxtghzGoHZ++83m44VmcaJvi37k72rr6LQXbbc7KmXA60qQf4TM e2S+OT5Ok2dUb7vIZBFAGpo= X-Google-Smtp-Source: AGHT+IHSsH0QBQ40QfCDIsQK6S+cS9Hr1BzA/tq2PbY90eJ/8d0Lsnt8b7NfWlZhmU1ealAgtHDLsA== X-Received: by 2002:a4a:2a43:0:b0:56e:a164:bfad with SMTP id x3-20020a4a2a43000000b0056ea164bfadmr6741749oox.7.1692629499002; Mon, 21 Aug 2023 07:51:39 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id b10-20020a4a98ca000000b0056d2dde4cb7sm3849293ooj.0.2023.08.21.07.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 07:51:38 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268107 Archived-At: Ola x Nilsson writes: > On Thu, Jul 20 2023, Stephen Berman wrote: > >> On Thu, 20 Jul 2023 16:11:33 -0300 Mauro Aranda >> wrote: >> >>> Stephen Berman writes: >>> >>>> On Sat, 15 Jul 2023 10:20:17 -0300 Mauro Aranda >>>  wrote: >>>> >>>>> Turns out this code introduces regressions when customizing faces. >>>>> >>>>> With emacs -Q: >>>>> M-x customize-face RET default >>>>> Action the State button and choose: "For All Kinds of Displays" >>>>> Action the Display menu and select "specific display" >>>>> Wrong type argument: number-or-marker-p, "        " >>>>> >>>>> The substitute-command-keys operation is too destructive, and messes >>>>> with things it shouldn't be modifying, like the :offset property of >>>>> widgets in this case. >>> >>>> Sorry for not responding sooner; I was travelling and only now had time >>>> to look into this.  If I debugged it correctly, the problem is that the >>>> value of :extra-offset, 9, satisfies char-or-string-p, so then due to my >>>> patch substitute-command-keys turns it into a string containing a TAB. >>> >>> No trouble at all.  And yes, that sounds correct to me. >>> >>>> The cases intended to be fixed by my patch are where strings with grave >>>> quoting occur, which should be turned into strings with curve quoting. >>>> If so, then testing for stringp suffices, and the attached patch avoids >>>> the regression you found and gives the desired results for the other >>>> cases discussed in this bug.  I don't know why I used char-or-string-p >>>> instead of stringp in my original patch, and don't see a reason for it >>>> now.  Or do you know of cases where testing for stringp is insufficient? >>> >>> I don't know, but I feel like stringp should suffice.  So please install >>> your fix, and I will be alert if something else breaks. >> >> Thanks, pushed to master as commit c55e67081e9. >> >> Steve Berman > > [Resending as the bug was archived] > > I think I ran into another problem with the change. > Using the simple item definitions (described in the docstring), this > call > > (widget-choose "Title" '(("Option1" . "Foo") ("Option 2" . "Bar"))) > > will fail with > > (wrong-type-argument (listp "Foo")) Thanks for reporting this. > Or did I misunderstand how that mode works? I think your recipe should work, and it worked before. Hopefully Stephen can take a look at it.