Re: master 3139551: Don’t attempt to modify constant strings

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On 5/18/20 12:03 AM, Andreas Schwab wrote:
> On Mai 17 2020, Paul Eggert wrote:
> 
>> That would run afoul of the whole idea of clearing the string in the first
>> place, which was to avoid having one's password lying around in memory for a bad
>> actor to grab it.
> 
> But doing it in the caller is equally bad.

True, thanks, I installed the attached.

[-- Attachment #2: 0001-Improve-password-cache-add-example-in-comment.patch --]
[-- Type: text/x-patch, Size: 895 bytes --]

From 4d6e592cf5f48ca8aab9ec6569759f25cd1d1677 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 18 May 2020 15:42:18 -0700
Subject: [PATCH] Improve password-cache-add example in comment

* lisp/password-cache.el: Improve comment.  See Andreas Schwab in:
https://lists.gnu.org/r/emacs-devel/2020-05/msg02422.html
---
 lisp/password-cache.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/password-cache.el b/lisp/password-cache.el
index 86d802f283..f5007579a8 100644
--- a/lisp/password-cache.el
+++ b/lisp/password-cache.el
@@ -31,7 +31,8 @@
 ;; ;; Minibuffer prompt for password.
 ;;  => "foo"
 ;;
-;; (password-cache-add "test" (copy-sequence "foo"))
+;; (password-cache-add "test" (read-passwd "Password? "))
+;; ;; Minibuffer prompt from read-passwd, which returns "foo".
 ;;  => nil
 
 ;; (password-read "Password? " "test")
-- 
2.25.4