From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#25706: 26.0.50; Slow C file fontification Date: Tue, 1 Dec 2020 13:03:21 +0100 Message-ID: <27B320DF-8102-4CDF-8C6A-7157EEAACF64@acm.org> References: <55C404DC-1C29-449F-9A49-B20EDFFCFCEA@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 25706@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 01 13:04:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kk4OK-0007U3-FZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Dec 2020 13:04:20 +0100 Original-Received: from localhost ([::1]:43688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kk4OJ-0000BJ-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Dec 2020 07:04:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kk4O2-0000B2-34 for bug-gnu-emacs@gnu.org; Tue, 01 Dec 2020 07:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kk4O1-0001pD-PK; Tue, 01 Dec 2020 07:04:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kk4O1-0004MP-Jt; Tue, 01 Dec 2020 07:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Tue, 01 Dec 2020 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25706 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 25706-submit@debbugs.gnu.org id=B25706.160682421316721 (code B ref 25706); Tue, 01 Dec 2020 12:04:01 +0000 Original-Received: (at 25706) by debbugs.gnu.org; 1 Dec 2020 12:03:33 +0000 Original-Received: from localhost ([127.0.0.1]:58180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk4NY-0004Lc-LV for submit@debbugs.gnu.org; Tue, 01 Dec 2020 07:03:32 -0500 Original-Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:45882 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kk4NW-0004LN-OS for 25706@debbugs.gnu.org; Tue, 01 Dec 2020 07:03:31 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1606824204; bh=bTx9MFDP75Tr+UJQCbR+VcpxVeMNngbRZXvvau1x3mk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Yrn/qBr0X1RAECne+PIAtd81y9LhOriUO/dvHbXiTilUh3Vruioh8MbMH+TjFWt7B HM0Rm2HacvXc9PxONCDNmqM4N2BMXrVORAeG+DHw71MVgNzvr7cEJCWhYK4q+MWKGT hZOURjvtFH6RTbk0PV6iGxfz+Q6t6r7GHYaGF/w8= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-064ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.6]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 0B1C3L0h006741; Tue, 1 Dec 2020 12:03:23 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F26.5FC6310C.0019, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=VaOJw2h9 c=1 sm=1 tr=0 a=Ni+dBsiEfW2GqKMPYZim9A==:117 a=Ni+dBsiEfW2GqKMPYZim9A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=I1rw0lla0B7aVgj8tygA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=Ew2E2A-JSTLzCXPT_086:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194731 Archived-At: 1 dec. 2020 kl. 10.21 skrev Alan Mackenzie : > (i) Take the first 10% of the original 4MB file, and save it in a > different file. > (ii) Fontify that file from top to bottom: according to EPL, 292s > (iii) Insert 9 new lines "{}" every 10% of that new file. > (iv) Fontify the amended file top to bottom: new time 98s. >=20 > That's a factor of 3 different. Thank you, quite remarkable and a very useful piece of information! Please let me curb some unwarranted optimism that I'm guilty of = engendering: We have been measuring slightly different things. Being lazy, I timed = the fontification in one go: (font-lock-ensure (point-min) (point-max)) which took about 65 s originally and went down to about 24 s by fixing = the regexps as previously mentioned. Much better but still not = wonderful. You have measured interactive scrolling which is more realistic, but = fontifying the buffer piecemeal it exercises slightly different code = paths. Fixing those regexps helps but not as much, and clearly more work = is needed. (By the way, could you direct me to your benchmark code? I don't think I = have it.) Still, improving regexps is clearly beneficial. Reducing allocation can = be effective as well; a fair bit of the profile is in the GC.