From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Scan of regexps in emacs Date: Mon, 11 Mar 2019 09:51:49 +0100 Message-ID: <279B4953-57A1-4065-BF44-CF5B6E0835ED@acm.org> References: <9f6f677b29f514c5f0bb1bb805e89d62eb146999.camel@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2964"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 11 09:55:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3Gik-0000dE-RT for ged-emacs-devel@m.gmane.org; Mon, 11 Mar 2019 09:55:43 +0100 Original-Received: from localhost ([127.0.0.1]:57642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3Gij-0000b2-RQ for ged-emacs-devel@m.gmane.org; Mon, 11 Mar 2019 04:55:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3GgG-0006rs-LP for emacs-devel@gnu.org; Mon, 11 Mar 2019 04:53:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3GgE-0003q8-I5 for emacs-devel@gnu.org; Mon, 11 Mar 2019 04:53:08 -0400 Original-Received: from mail156c50.megamailservers.eu ([91.136.10.166]:48320 helo=mail51c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3GgA-00036n-Q0 for emacs-devel@gnu.org; Mon, 11 Mar 2019 04:53:04 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1552294311; bh=KCG087IAwR+GT3aNexD0nPln2uy+5cgJjYb+ub8RTFg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=LbI8Gvi/ye+LAgUdutG+OMegJkMP+rzLVnj3/rg41vi03BZEfx62cP40hj1zsT3iF I2EMKoz1JoZu5/a0/aUPWrlWgr7kp+mGRN5BO9femAdrGna+eupxm7X3Z7WP07GSry 1DCL0CUar6MOk3BrpXzLofz10I6XCKnqpLMgcM9U= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.64] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x2B8pnbq021391; Mon, 11 Mar 2019 08:51:51 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.102.3) X-CTCH-RefID: str=0001.0A0B020D.5C8621A7.004C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=a8seC3aF c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=IkcTkHD0fZMA:10 a=Jm3hQKyCpbSBbzStJpYA:9 a=QEXdDO2ut3YA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.10.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234058 Archived-At: 11 mars 2019 kl. 03.45 skrev Paul Eggert : >=20 > Mattias Engdeg=C3=A5rd wrote: >> Here is a new regexp error scan of the Emacs source tree. >=20 > Thanks. Alan fixed some of them and I installed the attached, which I = hope fixes the rest. Thank you, and it looks good. Maybe one tweak: --- a/lisp/language/china-util.el +++ b/lisp/language/china-util.el @@ -168,4 +168,4 @@ encode-hz-region ;; ESC ESC -> ESC (delete-char 1) (forward-char -1) - (if (looking-at iso2022-gb-designation) + (if (looking-at "\e\\$A") What about (regexp-quote iso2022-gb-designation) instead, possibly = hoisted? (Of course the reader then wonders why iso2022-ascii-designation isn't = quoted. Oh dear.)