From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nikolay Kudryavtsev Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 2 Jan 2017 21:43:39 +0300 Message-ID: <27731f0d-8eb5-9647-f4b6-19141b1aa9bd@gmail.com> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> <8760nzfunl.fsf@gmx.de> <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> <158f0095-926f-2b8e-034c-4a05a1f08175@yandex.ru> <3e723e03-6fff-7500-aa91-e8de73519490@gmail.com> <52d971c7-2c28-84f7-437f-3aa0ce0b62bb@gmail.com> <87zij96480.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------0ACF15F4D6C02D5C70718491" X-Trace: blaine.gmane.org 1483382683 9588 195.159.176.226 (2 Jan 2017 18:44:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Jan 2017 18:44:43 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 Cc: emacs-devel@gnu.org, Dmitry Gutov To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 02 19:44:39 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cO7ay-00010o-PV for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 19:44:33 +0100 Original-Received: from localhost ([::1]:58495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO7b1-0001DY-AL for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 13:44:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO7aD-0001C4-Ua for emacs-devel@gnu.org; Mon, 02 Jan 2017 13:43:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cO7aA-0005rZ-S6 for emacs-devel@gnu.org; Mon, 02 Jan 2017 13:43:45 -0500 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:35376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cO7aA-0005rJ-JE for emacs-devel@gnu.org; Mon, 02 Jan 2017 13:43:42 -0500 Original-Received: by mail-lf0-x229.google.com with SMTP id b14so273838896lfg.2 for ; Mon, 02 Jan 2017 10:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to; bh=nlWfVngsf8p9f9KANPflG7Vo+hBduZqtdQt+MYToUPg=; b=DGZZ1DISiFumtVW/+Srg4cZGpQb340T4FtpU/i1bZIpSHgLfpVZJ3OaiZXVmX3+PWc 91sUbjofUw32AbZpTkn9OJByTFUsq0d1uJLuBAKMz6iDlJO4fLPbTagNGg5y0IEnoTQe 2kGdJWhZdao8bh9HDX8v3j6dPO2TSPIebPsFSoj1oWhm/f3d2lKvel9DeYEv/OVY0mY6 wS1PiKH5mxjkuaodYAdo8f3/xRHXomYiM0c31rB78SO1xLW5V8PWNVdUy3eGFiTGzsCb qDiiDtBP6YfSM6EKwUYB0p1Qgum6ucq/XjZynzZ5W9nIhlTPFqlrU/MfCVpR9Q4WOGy9 BqRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to; bh=nlWfVngsf8p9f9KANPflG7Vo+hBduZqtdQt+MYToUPg=; b=N9EFT5KZ3tUb7YW6KR7cfCvTtpoHb5NduAwAJvZusihbJi5HhZC0WFpMgXru5yS2xj 82qILmq5TFwbyA7a5ZsPbZgcDcmnFBD2SG/5OqJ7smxGEEpKZ64gLVLcSysaN8dzG4pI NHV7f8xJ2l8gPJvJmAIEHoeSQMH7R+ILE5oij1caq6JeVLZfh4C4lEhJYxeM08SmkUqa sGo1c1yS6MlrF4yOiYqCpp8ifN1JMQqW55evkNkY1o66NcS5XKLhKgmEVQKpBj71SWNI uPnz9LXs87WfZFfZHxXFcddFiPS1ypp1RLcmCSlYe3fBFbGCcBNHaJhVXGNZ/qMINlTB PVew== X-Gm-Message-State: AIkVDXIBv4+32HSNHGR4PvavkS3C/bEBIjqgbYMosSUr0bqWhAtE9A5gcD3KcY1uEC37xQ== X-Received: by 10.46.9.21 with SMTP id 21mr21734401ljj.0.1483382620958; Mon, 02 Jan 2017 10:43:40 -0800 (PST) Original-Received: from [192.168.199.6] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id e6sm8945537lji.34.2017.01.02.10.43.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2017 10:43:40 -0800 (PST) X-Google-Original-From: Nikolay Kudryavtsev In-Reply-To: <87zij96480.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211068 Archived-At: This is a multi-part message in MIME format. --------------0ACF15F4D6C02D5C70718491 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Michael. Just to be clear - we're talking about the current master. That one does not work. My original patch, or your rewrite in this thread works. So here's what happens. 1. Msg-file has a local name as its value. Let's say I'm trying to commit into repository /pscp:server:/home/user/git-test/. Make-nearby-temp-file creates a file "/pscp:server:/home/user/git-test/git-msg23408zHn". Msg-file becomes "/home/user/git-test/git-msg23408zHn". 2. We concat a git command like "git commit /home/user/git-test/git-msg23408zHn". No problem here, since we need a local name. 3. (write-region (car args) nil msg-file) happens and it fails, because local name "/home/user/git-test/git-msg23408zHn" expands to "c:/home/user/git-test/git-msg23408Ncz" which is a file on a local machine and it does not exist. The fix would be having absolute name for msg-file(/pscp:server:/home/user/git-test/git-msg23408zHn) and then using (or (file-remote-p msg-file 'localname) msg-file) for git commit. Everywhere else we need the absolute name. I've attached those changes as patch. -- Best Regards, Nikolay Kudryavtsev --------------0ACF15F4D6C02D5C70718491 Content-Type: text/plain; charset=UTF-8; name="remote-vc-git-master-fixed.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="remote-vc-git-master-fixed.patch" ZGlmZiAtLWdpdCBsaXNwL3ZjL3ZjLWdpdC5lbCBsaXNwL3ZjL3ZjLWdpdC5lbA0KaW5kZXgg YzY3MDI4MC4uNjE2YzE1MCAxMDA2NDQNCi0tLSBsaXNwL3ZjL3ZjLWdpdC5lbA0KKysrIGxp c3AvdmMvdmMtZ2l0LmVsDQpAQCAtNzA3LDE0ICs3MDcsMTYgQEANCiAgICAgICAgICAgOzsg bWVzc2FnZS4gIEhhbmRsZSBhbHNvIHJlbW90ZSBmaWxlcy4NCiAgICAgICAgICAgKGlmIChl cSBzeXN0ZW0tdHlwZSAnd2luZG93cy1udCkNCiAgICAgICAgICAgICAgIChsZXQgKChkZWZh dWx0LWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBmaWxlMSkpKQ0KLSAgICAgICAg ICAgICAgICAoZmlsZS1sb2NhbC1uYW1lIChtYWtlLW5lYXJieS10ZW1wLWZpbGUgImdpdC1t c2ciKSkpKSkpDQorICAgICAgICAgICAgICAgIChtYWtlLW5lYXJieS10ZW1wLWZpbGUgImdp dC1tc2ciKSkpKSkNCiAgICAgKGNsLWZsZXQgKChib29sZWFuLWFyZy1mbg0KICAgICAgICAg ICAgICAgIChhcmd1bWVudCkNCiAgICAgICAgICAgICAgICAobGFtYmRhICh2YWx1ZSkgKHdo ZW4gKGVxdWFsIHZhbHVlICJ5ZXMiKSAobGlzdCBhcmd1bWVudCkpKSkpDQogICAgICAgOzsg V2hlbiBvcGVyYXRpbmcgb24gdGhlIHdob2xlIHRyZWUsIGJldHRlciBwYXNzICItYSIgdGhh biAiLiIsIHNpbmNlICIuIg0KICAgICAgIDs7IGZhaWxzIHdoZW4gd2UncmUgY29tbWl0dGlu ZyBhIG1lcmdlLg0KICAgICAgIChhcHBseSAndmMtZ2l0LWNvbW1hbmQgbmlsIDAgKGlmIG9u bHkgZmlsZXMpDQotICAgICAgICAgICAgIChuY29uYyAoaWYgbXNnLWZpbGUgKGxpc3QgImNv bW1pdCIgIi1GIiBtc2ctZmlsZSkNCisgICAgICAgICAgICAgKG5jb25jIChpZiBtc2ctZmls ZSAobGlzdCAiY29tbWl0IiAiLUYiDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKG9yIChmaWxlLXJlbW90ZS1wIG1zZy1maWxlICdsb2NhbG5hbWUpDQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1zZy1maWxlKSkNCiAg ICAgICAgICAgICAgICAgICAgICAgKGxpc3QgImNvbW1pdCIgIi1tIikpDQogICAgICAgICAg ICAgICAgICAgICAobGV0ICgoYXJncw0KICAgICAgICAgICAgICAgICAgICAgICAgICAgIChs b2ctZWRpdC1leHRyYWN0LWhlYWRlcnMNCg== --------------0ACF15F4D6C02D5C70718491--