From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce Newsgroups: gmane.emacs.bugs Subject: bug#59139: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected Date: Sat, 12 Nov 2022 17:01:52 +0100 Message-ID: <27609d06-c428-d6f4-e7a3-fa9427d99895@orange.fr> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28999"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: 59139@debbugs.gnu.org, 59115@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 17:02:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otsxf-0007PU-Fb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 17:02:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otsxI-00007Q-K4; Sat, 12 Nov 2022 11:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otsxG-00006j-O1 for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 11:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otsxG-0003v2-Fo for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 11:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otsxG-00062g-AE for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 11:02:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59139 X-GNU-PR-Package: emacs Original-Received: via spool by 59139-submit@debbugs.gnu.org id=B59139.166826891823210 (code B ref 59139); Sat, 12 Nov 2022 16:02:02 +0000 Original-Received: (at 59139) by debbugs.gnu.org; 12 Nov 2022 16:01:58 +0000 Original-Received: from localhost ([127.0.0.1]:48830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otsxC-00062D-KH for submit@debbugs.gnu.org; Sat, 12 Nov 2022 11:01:58 -0500 Original-Received: from smtp-18.smtpout.orange.fr ([80.12.242.18]:57472 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otsxA-00061w-Bv for 59139@debbugs.gnu.org; Sat, 12 Nov 2022 11:01:57 -0500 Original-Received: from [192.168.1.15] ([2.7.97.237]) by smtp.orange.fr with ESMTPA id tsx6opWgftk1atsx6osxwz; Sat, 12 Nov 2022 17:01:54 +0100 X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Nov 2022 17:01:54 +0100 X-ME-IP: 2.7.97.237 Content-Language: fr, en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247665 Archived-At: Hello, If I correctly understood the code, a fix similar to the one applied for Bug#59115 is also needed for directories. Please find below another patch. Please also feel free to close this Bug#59139. diff --git a/bytecomp.el b/bytecomp.el index c685e50..c81c42e 100644 --- a/bytecomp.el +++ b/bytecomp.el @@ -1941,11 +1941,10 @@ also be compiled." ;; This file is a subdirectory. Handle them differently. (or (null arg) (eq 0 arg) (y-or-n-p (concat "Check " source "? "))) - (setq directories (nconc directories (list source))) ;; Directory is requested to be ignored - (string-match-p - (regexp-opt byte-compile-ignore-files) - source) + (not (string-match-p + (regexp-opt byte-compile-ignore-files) + source)) (setq directories (nconc directories (list source)))) ;; It is an ordinary file. Decide whether to compile it. (if (and (string-match emacs-lisp-file-regexp source) Thanks!