From: Bill Wohler <wohler@newt.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25552@debbugs.gnu.org, mkupfer@alum.berkeley.edu
Subject: bug#25552: 26.0.50; load cl unintendedly
Date: Sun, 30 Apr 2017 22:10:40 -0700 [thread overview]
Message-ID: <27497.1493615440__17345.818601507$1493615533$gmane$org@olgas.newt.com> (raw)
In-Reply-To: <CAM-tV-9fuKGbSBY8sDfL5MvAq0iAua5-4USgRrD11AQ+C52Avg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
Noam Postavsky <npostavs@users.sourceforge.net> wrote:
> On Thu, Apr 13, 2017 at 9:30 PM, Mike Kupfer <mkupfer@alum.berkeley.edu> wrote:
> >
> >> I thought we had switched to just supporting the current Emacs
> >> version, rather than doing a separate MH-E release that supports
> >> multiple Emacs versions.
> >
> > Yes, I've confirmed with Bill Wohler that that's what we're doing.
> >
> > I'm happy for either you or Glenn to push those patches, but I can do it
> > if you prefer (probably next week sometime).
> >
> > Oh, and to close the loop with some suggestions that Glenn made back in
> > February (e.g., use cl-lib instead of cl)... I do plan to look into
> > those suggestions, but I don't know how long it will take me. So fixing
> > the immediate cl problem now seems to me like a good thing.
>
> That all sounds fine, push at your convenience, there's no special urgency.
I tested what I think we have so far (appended) and haven't noticed
anything amiss. Please push what you have at your convenience, as I
don't think I see it on master yet.
I tried to add eval-and-compile to mailabbrev, but got the following
compilation error:
mh-e/mh-compat.el:263:1:Error: Symbol’s function definition is void: mh-require
--
Bill Wohler <wohler@newt.com> aka <Bill.Wohler@nasa.gov>
http://www.newt.com/wohler/
GnuPG ID:610BD9AD
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mh-e.diff --]
[-- Type: text/x-diff, Size: 1540 bytes --]
diff --git a/lisp/mh-e/mh-acros.el b/lisp/mh-e/mh-acros.el
index 0c89efbe3c..2e778eafb9 100644
--- a/lisp/mh-e/mh-acros.el
+++ b/lisp/mh-e/mh-acros.el
@@ -81,7 +81,7 @@ mh-do-in-xemacs
;;;###mh-autoload
(defmacro mh-funcall-if-exists (function &rest args)
"Call FUNCTION with ARGS as parameters if it exists."
- (when (fboundp function)
+ (when (fboundp function)
`(when (fboundp ',function)
(funcall ',function ,@args))))
@@ -90,10 +90,9 @@ defun-mh
"Create function NAME.
If FUNCTION exists, then NAME becomes an alias for FUNCTION.
Otherwise, create function NAME with ARG-LIST and BODY."
- (let ((defined-p (fboundp function)))
- (if defined-p
- `(defalias ',name ',function)
- `(defun ,name ,arg-list ,@body))))
+ `(if (fboundp ',function)
+ (defalias ',name ',function)
+ (defun ,name ,arg-list ,@body)))
(put 'defun-mh 'lisp-indent-function 'defun)
(put 'defun-mh 'doc-string-elt 4)
diff --git a/lisp/mh-e/mh-compat.el b/lisp/mh-e/mh-compat.el
index 3f3990e869..099fc9bbba 100644
--- a/lisp/mh-e/mh-compat.el
+++ b/lisp/mh-e/mh-compat.el
@@ -40,7 +40,7 @@
;; Items are listed alphabetically (except for mh-require which is
;; needed sooner it would normally appear).
-(require 'mh-acros)
+(eval-when-compile (require 'mh-acros))
(mh-do-in-gnu-emacs
(defalias 'mh-require 'require))
@@ -374,7 +374,6 @@ mh-write-file-functions
(provide 'mh-compat)
;; Local Variables:
-;; no-byte-compile: t
;; indent-tabs-mode: nil
;; sentence-end-double-space: nil
;; End:
next prev parent reply other threads:[~2017-05-01 5:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 1:24 bug#25552: 26.0.50; load cl unintendedly Katsumi Yamaoka
2017-01-27 1:50 ` Katsumi Yamaoka
2017-01-29 17:03 ` npostavs
2017-01-30 3:37 ` Mark Oteiza
2017-01-30 22:35 ` Glenn Morris
2017-01-31 22:39 ` Glenn Morris
2017-02-01 1:09 ` Katsumi Yamaoka
[not found] ` <b4m60kuk98u.fsf@jpl.org>
2017-02-01 4:02 ` Mike Kupfer
[not found] ` <17104.1485921740@alto>
2017-02-01 13:51 ` npostavs
2017-02-03 2:05 ` Mike Kupfer
2017-02-03 2:21 ` Jeffrey Honig
[not found] ` <CAC5WE8qFGjt5bLsbVJrvUttPOom8nN+Xe-WuW1zTvpaHvf=5BQ@mail.gmail.com>
2017-02-03 6:30 ` Bill Wohler
2017-02-06 1:25 ` Jeffrey Honig
2017-02-06 2:03 ` Glenn Morris
2017-04-09 12:01 ` npostavs
2017-04-09 14:25 ` Mike Kupfer
2017-04-14 1:30 ` Mike Kupfer
[not found] ` <12659.1492133413@alto>
2017-04-14 14:36 ` Noam Postavsky
2017-04-14 17:05 ` Glenn Morris
[not found] ` <4mefwu2a3a.fsf@fencepost.gnu.org>
2017-04-15 18:17 ` Bill Wohler
[not found] ` <CAM-tV-9fuKGbSBY8sDfL5MvAq0iAua5-4USgRrD11AQ+C52Avg@mail.gmail.com>
2017-05-01 5:10 ` Bill Wohler [this message]
[not found] ` <27497.1493615440@olgas.newt.com>
2017-05-01 13:43 ` Mike Kupfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='27497.1493615440__17345.818601507$1493615533$gmane$org@olgas.newt.com' \
--to=wohler@newt.com \
--cc=25552@debbugs.gnu.org \
--cc=mkupfer@alum.berkeley.edu \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.