From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org
Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q
Date: Sun, 9 Jul 2023 20:12:38 -0300 [thread overview]
Message-ID: <26d4603c-302c-8de9-fb22-8d0720516bb0@gmail.com> (raw)
In-Reply-To: <83lefp9tbd.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sun, 9 Jul 2023 08:44:23 -0300
>> Cc: 64347@debbugs.gnu.org, stephen.berman@gmx.net
>> From: Mauro Aranda <maurooaranda@gmail.com>
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > I guess I'm missing something here: why do we need those pre-filter
>> > and post-filter conversions? The C code understands both forms of
>> > :line-width, so there should be no need for Lisp to do any
>> > conversions, right? So why do we do that? why not simply leave the
>> > spec as it was originally?
>>
>> Custom needs the pre-filter in order to present a Custom buffer to edit
>> the face.
>> Let's say there's a face:
>> (defface foo
>> '((t (:box (:line-width 1 :color "black"))))
>> "...")
>>
>> And let's say a user wants to customize it via Custom.
>> M-x customize-face RET foo
>> should show the user a buffer with all the capabilities to edit it.
>> Because we have an integer for the :line-width property, the user will
>> be presented with an integer Widget to edit the value, without giving
>> the user the opportunity to edit the HWIDTH and VWIDTH separately.
>>
>> So the pre-filter takes the (:line-width 1), and converts it into
>> (:line-width (1 . 1)), and now the Custom buffer will have
>> a cons Widget. If we didn't do that conversion, that would be a Bug
>> report, I'm sure.
>
> OK, but why does it have to do that on the original value? It could
> do that on a copy that serves for the display and editing, in which
> case the original value could be left intact if the user didn't change
> it or did change, but didn't click Apply. (If the user does modify
> the original value, then any conversions are okay, since the variable
> is really "edited".)
I think my description was inaccurate, because it seemed to imply that
it is a destructive operation. It is not, it leaves the original value
intact.
But when deciding to set a state, Custom always consults the spec built
from the data the face Widget has.
next prev parent reply other threads:[~2023-07-09 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:15 bug#64347: 30.0.50; Some customize faces shown as edited with -Q Stephen Berman
2023-06-29 12:38 ` Eli Zaretskii
2023-06-30 11:33 ` Mauro Aranda
2023-06-30 12:43 ` Drew Adams
2023-06-30 14:05 ` Mauro Aranda
2023-07-08 7:49 ` Eli Zaretskii
2023-07-08 21:32 ` Mauro Aranda
2023-07-09 5:43 ` Eli Zaretskii
2023-07-09 11:44 ` Mauro Aranda
2023-07-09 12:13 ` Eli Zaretskii
2023-07-09 23:12 ` Mauro Aranda [this message]
2023-07-10 12:47 ` Eli Zaretskii
2023-07-10 13:45 ` Mauro Aranda
2023-07-15 20:01 ` Mauro Aranda
2023-07-20 15:45 ` Eli Zaretskii
2023-07-15 20:11 ` Mauro Aranda
2023-07-20 15:49 ` Eli Zaretskii
2023-07-20 18:56 ` Mauro Aranda
2023-07-20 19:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d4603c-302c-8de9-fb22-8d0720516bb0@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64347@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.