From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string Date: Sun, 4 Jun 2017 12:38:10 -0700 (PDT) Message-ID: <26a213b3-908e-43b1-a009-b8a18f0a1c23@default> References: <<06a7cc83-a2a8-45a0-97d4-bd3a478aab92@default>> <<83wp8ra9g6.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1496605153 27282 195.159.176.226 (4 Jun 2017 19:39:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Jun 2017 19:39:13 +0000 (UTC) Cc: 27238@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 04 21:39:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHbMj-0006u6-8Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jun 2017 21:39:09 +0200 Original-Received: from localhost ([::1]:58357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHbMo-0000bi-L5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jun 2017 15:39:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHbMg-0000bP-Bv for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 15:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHbMd-0004oS-A3 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 15:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHbMd-0004o9-6d for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 15:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHbMc-0007Fc-Bn for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2017 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2017 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27238 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27238-submit@debbugs.gnu.org id=B27238.149660510127825 (code B ref 27238); Sun, 04 Jun 2017 19:39:02 +0000 Original-Received: (at 27238) by debbugs.gnu.org; 4 Jun 2017 19:38:21 +0000 Original-Received: from localhost ([127.0.0.1]:56141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHbLx-0007Ej-F3 for submit@debbugs.gnu.org; Sun, 04 Jun 2017 15:38:21 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:45614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHbLv-0007EV-5W for 27238@debbugs.gnu.org; Sun, 04 Jun 2017 15:38:19 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v54JcBxP015024 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Jun 2017 19:38:12 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v54JcBnm012813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Jun 2017 19:38:11 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v54JcA1l010389; Sun, 4 Jun 2017 19:38:10 GMT In-Reply-To: <<83wp8ra9g6.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6767.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133270 Archived-At: > > This is a useful, general function, not just a helper. >=20 > FWIW, I don't think it's general enough, because it is tightly couples > with face-x-resources. That's only the _implementation_. (That reasoning would apply also to `face-spec-recalc', `face-spec-set', `face-set-after-frame-default', `custom-face-set', `custom-face-save', `custom-face-mark-to-save', `custom-face-reset-saved', `custom-face-mark-to-reset-standard', `custom-declare-face', `custom-theme-set-faces', `custom-reset-faces', `woman-default-faces', ...) Unless you essentially repeat its body, it is the only way to do what it does. Here's one use case: (face-spec-set-2 TARGET-FACE FRAME (face-spec-choose (get SOURCE-FACE 'face-defface-spec) FRAME))