all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephan Bergmann <Stephan.Bergmann@Sun.COM>
To: 5456@debbugs.gnu.org
Subject: bug#5456: vc-hg-state does not search hg in vc-path
Date: Fri, 22 Jan 2010 23:05:58 +0100	[thread overview]
Message-ID: <26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com> (raw)

At least in 23.1, vc-hg-state (and vc-hg-working-revision) in vc-hg.el call "hg" without making sure that it is being searched for in vc-path (as is done in vc-dispatcher.el by extending exec-path).  What fixed it for me (on recent trunk) is

---8<---
=== modified file 'lisp/vc-hg.el'
--- lisp/vc-hg.el	2010-01-13 08:35:10 +0000
+++ lisp/vc-hg.el	2010-01-22 21:46:14 +0000
@@ -169,7 +169,8 @@
                       ;; Ignore all errors.
 		      (let ((process-environment
 			     ;; Avoid localization of messages so we can parse the output.
-			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment)))
+			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=") process-environment))
+                            (exec-path (append vc-path exec-path)))
 
 		      (process-file
                        "hg" nil t nil
@@ -205,7 +206,8 @@
 		      (let ((process-environment
 			     ;; Avoid localization of messages so we can parse the output.
 			     (append (list "TERM=dumb" "LANGUAGE=C" "HGRC=")
-				     process-environment)))
+				     process-environment))
+                            (exec-path (append vc-path exec-path)))
 			;; Ignore all errors.
 			(process-file
 			 "hg" nil t nil

---8<---

-Stephan







             reply	other threads:[~2010-01-22 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 22:05 Stephan Bergmann [this message]
2010-01-25  6:16 ` bug#5456: vc-hg-state does not search hg in vc-path Dan Nicolaescu
2010-01-25 15:35   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26BBB3D3-37BA-4E83-A9C3-16247D4D8241@sun.com \
    --to=stephan.bergmann@sun.com \
    --cc=5456@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.