From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Uberti via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52349: 29.0.50; vc-git and diff-mode: stage hunks Date: Tue, 7 Dec 2021 09:59:23 +0100 Message-ID: <268cee0d-465d-b862-d1d6-f5da4d69e737@inventati.org> Reply-To: Manuel Uberti Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 To: 52349@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 07 10:00:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1muWKq-0000MN-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 10:00:28 +0100 Original-Received: from localhost ([::1]:52662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1muWKo-00080Y-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Dec 2021 04:00:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45240) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muWKR-0007yd-FA for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 04:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1muWKR-0005WV-0R for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 04:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1muWKQ-0002JR-SP for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Uberti Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Dec 2021 09:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52349 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16388675728817 (code B ref -1); Tue, 07 Dec 2021 09:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Dec 2021 08:59:32 +0000 Original-Received: from localhost ([127.0.0.1]:36337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muWJw-0002I9-Du for submit@debbugs.gnu.org; Tue, 07 Dec 2021 03:59:32 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1muWJu-0002I2-Pv for submit@debbugs.gnu.org; Tue, 07 Dec 2021 03:59:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muWJu-0007H8-7K for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 03:59:30 -0500 Original-Received: from [2001:888:2000:56::19] (port=20387 helo=latitanza.investici.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1muWJr-0005TY-0g for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2021 03:59:30 -0500 Original-Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4J7Z3w0WTmzGp4j for ; Tue, 7 Dec 2021 08:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1638867564; bh=8ho1PUiw3cC5crSr/NnfAsr3YDBPfQC31b59tYyfJFI=; h=To:Subject:From:Date:From; b=Z81zb+blckpcR3MmosXFHKi38yWG/+HC2fhly3VtJIpnw+CC1vMbJoC7GPsGI27q9 koESZJmKW/NQUzzFRw89YrIqcZRWK5umtN9s4pHoWVObhslLzDtjCY6qudtHRIguye EJmbg7tNBtrb+/NqAPxUbKDR0G3X8HcNvtGOYSBA= Original-Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: manuel.uberti@inventati.org) by localhost (Postfix) with ESMTPSA id 4J7Z3v6s3nzGp4X for ; Tue, 7 Dec 2021 08:59:23 +0000 (UTC) Content-Language: en-GB X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:888:2000:56::19 (failed) Received-SPF: pass client-ip=2001:888:2000:56::19; envelope-from=manuel.uberti@inventati.org; helo=latitanza.investici.org X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221822 Archived-At: I don't know if I am missing something, but I don't think staging specific hunks from vc-git-mode or diff-mode is possible at the moment. Is adding such a capability to one (or both) of these modes worth considering? I know Magit does it, and I remember something similar in a git-gutter package. It's probably something diff-hl does as well by now (I have not checked). I feel like it'd be a nice improvement to VC, what do you think? Thank you In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.18, cairo version 1.16.0) of 2021-12-07 built on hathaway Repository revision: 9a1e87ba4486df19259abf3564a0281d8be25e64 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Ubuntu 20.04 LTS Configured using: 'configure --with-harfbuzz --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_MONETARY: it_IT.UTF-8 value of $LC_NUMERIC: it_IT.UTF-8 value of $LC_TIME: it_IT.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: VC dir Minor modes in effect: vc-parent-buffer: .emacs.d/*vc-dir* shell-dirtrack-mode: t electric-pair-mode: t vc-dir-git-mode: t savehist-mode: t global-so-long-mode: t global-subword-mode: t subword-mode: t windmove-mode: t winner-mode: t global-company-mode: t company-mode: t envrc-global-mode: t envrc-mode: t fido-vertical-mode: t icomplete-vertical-mode: t icomplete-mode: t fido-mode: t delete-selection-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/transient-0.3.7.0.20211107.234631/transient hides /usr/local/share/emacs/29.0.50/lisp/transient Features: (shadow sort mail-extr help-fns radix-tree emacsbug sendmail tramp-cmds mm-archive message yank-media rfc822 mml mml-sec epa gnus-util rmail rmail-loaddefs mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils mule-util gnutls url-cache epg rfc6068 epg-config hl-line finder-inf misearch multi-isearch pkg-info url-http url-auth url-gw find-func epl network-stream puny nsm rmc cider tramp-sh cider-debug cider-browse-ns cider-repl-history pulse derived sh-script smie executable find-dired cider-mode cider-find cider-inspector cider-completion cider-profile cider-eval cider-repl cider-resolve cider-eldoc cider-test cider-stacktrace cider-doc advice cider-browse-spec cider-clojuredocs cider-overlays cider-jar arc-mode archive-mode cider-client cider-common cider-connection cider-util color cider-popup sesman-browser nrepl-client tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 ls-lisp format-spec queue nrepl-dict cider-compat spinner parseedn parseclj-parser parseclj-lex parseclj-alist flymake-kondor sesman clojure-mode align imenu smerge-mode diff vc-dir ewoc time-date noutline outline checkdoc lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr dired-x dired dired-loaddefs elec-pair flymake-proc flymake compile text-property-search comint flyspell ispell goto-addr thingatpt pp vc-git diff-mode easy-mmode vc vc-dispatcher cursor-sensor server modus-operandi-theme modus-themes delight comp comp-cstr warnings cl-extra help-mode savehist so-long cap-words superword subword windmove winner company-oddmuse company-keywords company-etags etags fileloop generator xref project ring company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company pcase envrc inheritenv ansi-color icomplete rx delsel info tex-site package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 539597 325220) (symbols 48 27815 1) (strings 32 136565 77490) (string-bytes 1 5745034) (vectors 16 47250) (vector-slots 8 1113451 95518) (floats 8 236 658) (intervals 56 2079 129) (buffers 992 30)) -- Manuel Uberti www.manueluberti.eu