all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>,
	Ashton Wiersdorf <ashton@wiersdorfmail.net>,
	Po Lu <luangruo@yahoo.com>
Cc: 74430@debbugs.gnu.org
Subject: bug#74430: 30.0.92; pixel-scroll-precision-mode hiding Eshell prompt after some commands
Date: Thu, 21 Nov 2024 10:37:08 -0800	[thread overview]
Message-ID: <2689fac8-0a2f-ed4e-b46e-afa4f36ab840@gmail.com> (raw)
In-Reply-To: <86cyiorh6m.fsf@gnu.org>

On 11/21/2024 2:53 AM, Eli Zaretskii wrote:
>> From: Ashton Wiersdorf <ashton@wiersdorfmail.net>
>> Date: Mon, 18 Nov 2024 10:52:27 -0700
>>
>> When the command finished, the Eshell prompt was almost entirely
>> obscured by the modeline.
>>
>> The bug does not manifest when I turn off
>> `pixel-scroll-precision-mode`.
>> It returns when I turn `pixel-scroll-precision-mode` back on.
> 
> Po Lu and Jim, could you look into this, please?

I'm only dimly aware of how 'pixel-scroll-precision-mode' works, but I 
seem to recall that it sets the window's vscroll to allow scrolling past 
*part* of a line. On the Eshell side, I believe the relevant function is 
'eshell-postoutput-scroll-to-bottom', which calls 'recenter' to scroll 
the window.

I'm guessing these interact badly, and what we actually want to do is to 
reset the vscroll when Eshell calls 'recenter'. However, I'm not sure 
what the best way to do this would be. Is there some better function 
Eshell can call that would handle this case correctly?





  reply	other threads:[~2024-11-21 18:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 17:52 bug#74430: 30.0.92; pixel-scroll-precision-mode hiding Eshell prompt after some commands Ashton Wiersdorf
2024-11-21 10:53 ` Eli Zaretskii
2024-11-21 18:37   ` Jim Porter [this message]
2024-11-21 23:59     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-22  6:58       ` Eli Zaretskii
2024-11-30 10:07         ` Eli Zaretskii
2024-12-14  9:38           ` Eli Zaretskii
2024-11-25  5:13 ` Jim Porter
2024-11-30 10:07   ` Eli Zaretskii
2024-12-14  9:38     ` Eli Zaretskii
2024-12-14 18:40       ` Ashton Wiersdorf
2024-12-15 19:10         ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2689fac8-0a2f-ed4e-b46e-afa4f36ab840@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=74430@debbugs.gnu.org \
    --cc=ashton@wiersdorfmail.net \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.