From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincenzo Pupillo Newsgroups: gmane.emacs.bugs Subject: bug#72814: 31.0.50; Add a variable controlling doxygen support in C/C++/Java? Date: Wed, 11 Sep 2024 11:40:17 +0200 Message-ID: <26605291.1r3eYUQgxm@3-191.divsi.unimi.it> References: <0708616B-CCE4-4AA5-81FA-FF41F2789018@gmail.com> <2150926.9o76ZdvQCi@fedora> <5EDA64BE-4612-4614-9CA4-D93BB30674A8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40419"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72814@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 11 11:41:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1soJqZ-000AJF-0s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Sep 2024 11:41:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soJqM-0007Wl-F1; Wed, 11 Sep 2024 05:40:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soJqK-0007Op-IP for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:40:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soJqK-0006Nc-8n for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:40:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=dOj68ytSos6VSEaOEmIHESX0TB7vmsqcMpBAZuTl8sE=; b=BBKUOzT7aX3gV2sAXA5y3tk228/SGbayerMThts9UjRFW2Gjr7eK2ueLXnDHUFbm0F0Xx7DxDzXjLdIMc2o2rrSSCxOmzp8F8LZ296BZwxhknBxDtgxmtulm8N3vAWVSrgIG5Flv3ALLO8IjTfMJHkL4pX5nJAE27p4wRild5KeGiGTY6RgouGZ97YXsGC8LkIiqbOblfb8fGuDp/m3DArJAMX54RV3PwPcBLwaR7TOdF82We1JD7Lb1O84xrMjyZ4MXbEnhj9AU6wkdFZbP5R/QdQtbIYn1wY4TMwIbySMVEuDSiDV5EW7hY6wIRKmIC3leCeVUt17cwhbFDhl3Wg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1soJqQ-0007QH-5v for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincenzo Pupillo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2024 09:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72814 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: 72814@debbugs.gnu.org, Bug Report Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.172604763328490 (code B ref -1); Wed, 11 Sep 2024 09:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Sep 2024 09:40:33 +0000 Original-Received: from localhost ([127.0.0.1]:37785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJpw-0007PR-Nm for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:40:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:50252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soJpv-0007PK-5I for submit@debbugs.gnu.org; Wed, 11 Sep 2024 05:40:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soJpo-0004bn-BG for bug-gnu-emacs@gnu.org; Wed, 11 Sep 2024 05:40:24 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soJpm-0006Kt-9z; Wed, 11 Sep 2024 05:40:23 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5becfd14353so6210128a12.1; Wed, 11 Sep 2024 02:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726047620; x=1726652420; darn=gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dOj68ytSos6VSEaOEmIHESX0TB7vmsqcMpBAZuTl8sE=; b=kh4rGxn9ZGjCvZoxt2i6vZqIGmMPb/jzllLNj1ZslsslmZNq/fiNLiM2ZNEG1As72E +PhQvpN6KpY4a0L4DI4Pa4qoaEEKxMS3tXqGI9e+UEqR+Xjlld+Drz4eV/LHIApEVhR3 mYCljRR0y8GN5vv5edqpN4cImG0ULBK1fsgCIdndAt1IiFKW3ZHx9rzmeIDblezQn+T4 rhu//4HddJOhhFAIJFuQ6HEMfgj2qbrjm1w5X+rI3mR4Zbh9LUZGkyvFpsZmc22W8ivf EqJdFva9jwrLSLlI/WWqMITyXZB6T5uPz8gxUQzfjxR2uRhNbgnyAbL/kf+nL3XLhBAj oxOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726047620; x=1726652420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dOj68ytSos6VSEaOEmIHESX0TB7vmsqcMpBAZuTl8sE=; b=HnErAfcyOdybl0XasiotrWt8uAWm1FU1Im/lj9DYByZ9JEa2UfAHOA8UQT19I3GS72 CX9vepmJKXpq6lGv4U6EQ4V7dL7yvBndLK7WKvK+132ilMhE3ZC8Kg8eup2IpyjGtZWs sXua9Ftzx7GKRo5phoiqqcxoW2HLzmSf0o3rN4JqzRMAiwzq0fBUUI6cGPmjmLFsk5a+ pq2DRvRbr7avml/r1LnypZ6jplJf2cEVQak491IXHkN1Vj2MYAlXlXRAwHb1vnZkdvQG HXYL8KM/LovLgSLw0QX7OsQdLNVKi7/73vEUrsDHY/DdnsTStz4LJO9w7ol15ZuOLEUV Olhg== X-Forwarded-Encrypted: i=1; AJvYcCWGOnve8yA9/MiPlIM1VLXDpO2Sywl3EWTdx1W82cXFX5X1lRfNsSY9fEjqucUrhfRW6dLu@gnu.org X-Gm-Message-State: AOJu0Yw66GDBAThLo3nQ5T12uqU/NwS1snKqkHo5EMxx3rt167N2za38 URxoaFGdIkn85pQ5PaVYqimPB1B4xC/Hm3k2T6Q9jgxVQk8d9vSy X-Google-Smtp-Source: AGHT+IFXyv/fLDSmWzHav6JX68Sxe9JSk6XwO0d1ULV5jsZNMKTT3EXFTICODQJQtY8Vz+YRlCc+Ow== X-Received: by 2002:a05:6402:2115:b0:5c4:8ac:ff80 with SMTP id 4fb4d7f45d1cf-5c408ad0316mr3442772a12.33.1726047619403; Wed, 11 Sep 2024 02:40:19 -0700 (PDT) Original-Received: from 3-191.divsi.unimi.it (3-191.divsi.unimi.it. [159.149.3.191]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3ebd424dasm5265879a12.9.2024.09.11.02.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 02:40:18 -0700 (PDT) In-Reply-To: <5EDA64BE-4612-4614-9CA4-D93BB30674A8@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=v.pupillo@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291592 Archived-At: In data mercoled=C3=AC 11 settembre 2024 06:53:32 CEST, Yuan Fu ha scritto: >=20 > > On Sep 9, 2024, at 2:50=E2=80=AFAM, Vincenzo Pupillo wrote: > >=20 > > In data marted=C3=AC 27 agosto 2024 14:22:16 CEST, Eli Zaretskii ha scr= itto: > >>> From: Yuan Fu > >>> Date: Mon, 26 Aug 2024 20:13:52 -0700 > >>> Cc: eliz@gnu.org, > >>>=20 > >>> vincenzo.pupillo@unimi.it > >>>=20 > >>> Yuan Fu writes: > >>>> X-Debbugs-CC: eliz@gnu.org , > >>>> vincenzo.pupillo@unimi.it > >>>>=20 > >>>> Should we add a custom option that controls whether to enable doxygen > >>>> support in c-ts-mode/c++-ts-mode/java-ts-mode? > >>>>=20 > >>>> Technically this isn=E2=80=99t a problem, since the doxygen support = is only > >>>> enabled if there=E2=80=99s doxygen grammar on the system. But many p= eople > >>>> (me) might install a grammar bundle that includes dozens of > >>>> grammars for convenience. Then the doxygen support would turn on when > >>>> the user doesn=E2=80=99t really intend to use it. > >>>>=20 > >>>> I propose we add custom options like c-ts-mode-enable-doxygen and se= t it > >>>> to t by default, so the default behavior is still to enable doxygen > >>>> support when the grammar for it exists, but people who don=E2=80=99t= want to pay > >>>> for it can turn it off by setting the option to nil. > >>>>=20 > >>>> Yuan > >>>=20 > >>> Eli, WDYT? > >>=20 > >> I'm okay with such an option, but it should be careful to check > >> whether the corresponding grammar library is available, and offer a > >> user-friendly diagnostic if not. > >=20 > > Try to take a look at this patch. Is it okay? > >=20 > > Vincenzo > > <0001-Add-a-user-option-to-disable-Doxygen-syntax-highligh.patch> >=20 > Thanks for taking this up! I won=E2=80=99t signal a warning if doxygen gr= ammar isn=E2=80=99t found. Imagine a user without doxygen grammar, and din= =E2=80=99t change c-ts-mode-enable-doxygen: they=E2=80=99ll get a warning w= henever they open a C file.=20 > We should either set c-ts-mode-enable-doxygen to nil by default, or not w= arn when doxygen grammar doesn=E2=80=99t exist. Otherwise, the patch looks = good to me. Okay, fine. But Eli said something different... What do we do? Vincenzo >=20 > Yuan >=20