all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 72814@debbugs.gnu.org
Subject: bug#72814: 31.0.50; Add a variable controlling doxygen support in C/C++/Java?
Date: Wed, 11 Sep 2024 11:40:17 +0200	[thread overview]
Message-ID: <26605291.1r3eYUQgxm@3-191.divsi.unimi.it> (raw)
In-Reply-To: <5EDA64BE-4612-4614-9CA4-D93BB30674A8@gmail.com>

In data mercoledì 11 settembre 2024 06:53:32 CEST, Yuan Fu ha scritto:
> 
> > On Sep 9, 2024, at 2:50 AM, Vincenzo Pupillo <v.pupillo@gmail.com> wrote:
> > 
> > In data martedì 27 agosto 2024 14:22:16 CEST, Eli Zaretskii ha scritto:
> >>> From: Yuan Fu <casouri@gmail.com>
> >>> Date: Mon, 26 Aug 2024 20:13:52 -0700
> >>> Cc: eliz@gnu.org,
> >>> 
> >>> vincenzo.pupillo@unimi.it
> >>> 
> >>> Yuan Fu <casouri@gmail.com> writes:
> >>>> X-Debbugs-CC: eliz@gnu.org <mailto:eliz@gnu.org>,
> >>>> vincenzo.pupillo@unimi.it
> >>>> 
> >>>> Should we add a custom option that controls whether to enable doxygen
> >>>> support in c-ts-mode/c++-ts-mode/java-ts-mode?
> >>>> 
> >>>> Technically this isn’t a problem, since the doxygen support is only
> >>>> enabled if there’s doxygen grammar on the system. But many people
> >>>> (me) might install a grammar bundle that includes dozens of
> >>>> grammars for convenience. Then the doxygen support would turn on when
> >>>> the user doesn’t really intend to use it.
> >>>> 
> >>>> I propose we add custom options like c-ts-mode-enable-doxygen and set it
> >>>> to t by default, so the default behavior is still to enable doxygen
> >>>> support when the grammar for it exists, but people who don’t want to pay
> >>>> for it can turn it off by setting the option to nil.
> >>>> 
> >>>> Yuan
> >>> 
> >>> Eli, WDYT?
> >> 
> >> I'm okay with such an option, but it should be careful to check
> >> whether the corresponding grammar library is available, and offer a
> >> user-friendly diagnostic if not.
> > 
> > Try to take a look at this patch. Is it okay?
> > 
> > Vincenzo
> > <0001-Add-a-user-option-to-disable-Doxygen-syntax-highligh.patch>
> 
> Thanks for taking this up! I won’t signal a warning if doxygen grammar isn’t found. Imagine a user without doxygen grammar, and din’t change c-ts-mode-enable-doxygen: they’ll get a warning whenever they open a C file. 
> We should either set c-ts-mode-enable-doxygen to nil by default, or not warn when doxygen grammar doesn’t exist. Otherwise, the patch looks good to me.

Okay, fine. But Eli said something different...
What do we do?

Vincenzo
> 
> Yuan
> 








  reply	other threads:[~2024-09-11  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <D6CB8DB6-0D4A-496D-8EFF-4C03BFCC6858@gmail.com>
2024-08-27  3:13 ` bug#72814: 31.0.50; Add a variable controlling doxygen support in C/C++/Java? Yuan Fu
2024-08-27  7:36   ` Vincenzo Pupillo
2024-08-27 12:22   ` Eli Zaretskii
2024-09-09  9:50     ` Vincenzo Pupillo
2024-09-11  4:53       ` Yuan Fu
2024-09-11  9:40         ` Vincenzo Pupillo [this message]
2024-09-11 12:05           ` Eli Zaretskii
2024-09-12  7:51             ` Yuan Fu
2024-09-12  8:31               ` Eli Zaretskii
2024-09-14 17:26                 ` Vincenzo Pupillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26605291.1r3eYUQgxm@3-191.divsi.unimi.it \
    --to=v.pupillo@gmail.com \
    --cc=72814@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.