Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning

[Jens Schmidt <jschmidt4gnu@vodafonemail.de>]

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

On 2023-12-14  21:27, Eli Zaretskii wrote:
>> Date: Thu, 14 Dec 2023 21:03:02 +0100
>> Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca
>> From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>>
>> I understood from your previous email [1] that the current location of
>> where "rmc" is loaded in loadup.el is not optimal.
> 
> Not "not optimal", incorrect.  It should be before leim-list.el.
> 
>> How about moving it to the block that also loads "minibuffer"?
> 
> Why risk issues that could cause?  I'd leave it the last loaded
> package.  We don't have any real reason to move it higher up, do we?

I thought it'd feel lonely there.  On a more serious note, there are
more files that seem to race for the last places ("cus-start", for
example), and I thought it would be helpful to have one candidate
less wanting for a special position.

Anyway, if it should be before leim-list.el, attached is it.


[-- Attachment #2: 0001-Move-preload-of-rmc-to-a-more-appropriate-place.patch --]
[-- Type: text/x-patch, Size: 1345 bytes --]

From 29973cba6200c1bb7659a2e02dc5aaa5195c654a Mon Sep 17 00:00:00 2001
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Date: Thu, 14 Dec 2023 20:47:22 +0100
Subject: [PATCH] ; Move preload of rmc to a more appropriate place

See discussion on
https://lists.gnu.org/archive/html/emacs-devel/2023-12/msg00309.html.

* lisp/loadup.el ("emacs-lisp/rmc"): Move preload to a more
appropriate place.
---
 lisp/loadup.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/loadup.el b/lisp/loadup.el
index 1f959464b23..d2a4c6a7cf7 100644
--- a/lisp/loadup.el
+++ b/lisp/loadup.el
@@ -387,6 +387,9 @@
     (load "tooltip"))
 (load "international/iso-transl") ; Binds Alt-[ and friends.
 
+;; Used by `kill-buffer', for instance.
+(load "emacs-lisp/rmc")
+
 ;; This file doesn't exist when building a development version of Emacs
 ;; from the repository.  It is generated just after temacs is built.
 (load "leim/leim-list.el" t)
@@ -406,9 +409,6 @@
       (message "Warning: Change in load-path due to site-load will be \
 lost after dumping")))
 
-;; Used by `kill-buffer', for instance.
-(load "emacs-lisp/rmc")
-
 ;; Actively check for advised functions during preload since:
 ;; - advices in Emacs's core are generally considered bad style;
 ;; - `Snarf-documentation' looses docstrings of primitives advised
-- 
2.30.2