all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: "João Távora" <joaotavora@gmail.com>
Cc: 72824@debbugs.gnu.org
Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity
Date: Thu, 29 Aug 2024 00:20:43 +0300	[thread overview]
Message-ID: <25f7bdb6-aa71-4ba7-98da-9ac56d23b4f6@gutov.dev> (raw)
In-Reply-To: <CALDnm50o83nHme=qAFB6pDvFdVRi_16jqXNrbMLEobwvGO8s5A@mail.gmail.com>

On 28/08/2024 12:03, João Távora wrote:
> On Tue, Aug 27, 2024 at 11:57 PM Dmitry Gutov <dmitry@gutov.dev> wrote:
> 
>> This change should help eliminate the inconsistency between parts of the
>> current completion style, but for the next release we might migrate to a
>> more "passthrough" one.
> 
> What's that?  Modulo bugs (one of which you've fixed recently) the "dumb"
> is the most passthrough one, except for the completion-ignore-case.
> Do you want to remove that?  I added it at some user request... seemed
> reasonable.  Maybe it's not.

"dumb" does some filtering in its all-completion call (the predicate arg 
is used for its return value, AFAICT).

A "passthrough" style would only add highlighting but not filter.

>> Or not, you know. I've seen users request prefix-only matching instead
>> of the fuzzy one provided by the language servers, and I'm sure there
>> will be ones who prefer to match case-sensitively only too.
> 
> There is no way to do that.  We don't have a say in what the server
> gives us.  If the user types foo and the server ignores "foobar" and
> prefers "farfromsober" or std::foobar for whatever scoring reason, then
> there's nothing we can do about it.

I suppose that can happen if total completions exceed the cutoff number.

> These users are continuously
> misinformed  about LSP inability to follow Emacs's completion styles,
> despite my frequent admonishing.
My observation from the sidelines is that people are still happier to 
have such half-measures available, rather than not: 
https://github.com/emacs-lsp/lsp-mode/issues/1653#issuecomment-1125055989

It might be a matter of expectations.





  reply	other threads:[~2024-08-28 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27  1:38 bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Dmitry Gutov
2024-08-27 14:36 ` João Távora
2024-08-27 14:38   ` João Távora
2024-08-27 22:57     ` Dmitry Gutov
2024-08-28  9:03       ` João Távora
2024-08-28 21:20         ` Dmitry Gutov [this message]
2024-08-27 23:23   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25f7bdb6-aa71-4ba7-98da-9ac56d23b4f6@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=72824@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.