From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process" Date: Sat, 25 May 2024 16:54:54 +0300 Message-ID: <25dad14a-397c-4052-908c-121e40bbef51@gutov.dev> References: <3a497741-2ad0-4919-b7c9-cdb36b0eb455@gutov.dev> <8734q7h35d.fsf@gmx.de> <87ttinfgoa.fsf@gmx.de> <861q5r2ric.fsf@gnu.org> <87o78vf9l2.fsf@gmx.de> <86sey711m6.fsf@gnu.org> <221919a1-950e-4ef3-975d-f86078d8e105@gutov.dev> <87wmnidv3u.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------fQ3ZOMRaB9VG8EfAneYa0De6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6700"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , 71049@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 15:56:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sArsh-0001ab-S8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 15:56:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sArsK-0004mN-Ij; Sat, 25 May 2024 09:55:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sArsJ-0004mE-BB for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:55:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sArsJ-0008MB-3n for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:55:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sArsQ-0007zR-5e for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 09:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71049 X-GNU-PR-Package: emacs Original-Received: via spool by 71049-submit@debbugs.gnu.org id=B71049.171664531330595 (code B ref 71049); Sat, 25 May 2024 13:56:02 +0000 Original-Received: (at 71049) by debbugs.gnu.org; 25 May 2024 13:55:13 +0000 Original-Received: from localhost ([127.0.0.1]:43548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArrd-0007xO-Ef for submit@debbugs.gnu.org; Sat, 25 May 2024 09:55:13 -0400 Original-Received: from wfhigh4-smtp.messagingengine.com ([64.147.123.155]:46695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArrb-0007ww-UF for 71049@debbugs.gnu.org; Sat, 25 May 2024 09:55:12 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 6766E180013E; Sat, 25 May 2024 09:54:58 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 25 May 2024 09:54:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1716645298; x=1716731698; bh=TI6th3hgSM 09pQNFwlk72z4+FPPwZA51arXG6+t37PI=; b=MYQ78fsQXwwfsDK/VC6uEU7lmC CKSnHEahyNgqAtv7GZ1pM/aj8nIF1h10F9PGrItU4lu2zezID6JDqlotj0l4yM3C pkcrFM0wFmaYt4bo+G6XcYSY+4JVHG0f58f10RHNXCJpASUbhsEj3bJShRdsR0i7 FDmZiAaaU2Ue0QCZrkCS1aL21MjzT4QLb5uO+vQYVqF9OYTsDaDPFuHrKWmhGXzh C4AKlSiKmwXu1q9lv1kqXQT6lIXdX6q+nwScBG7kdAgXpNGXEGNE1dSi1E4JvnSa C4RwZz5CfqmlnlPmA/z/yWUOxkqNRMCcdeqLLsmHYjm/7boeHL4yOWTynW+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1716645298; x=1716731698; bh=TI6th3hgSM09pQNFwlk72z4+FPPw ZA51arXG6+t37PI=; b=K3okHVtKzf0HXpXIwfPRODR69MAaiYI1eI4ggs/0I2rS EbcSyEMP5r0K2DzFivOQPgvZd885s0rsknctWRNXdPxIChkstrf8SGya6gnLqokm lQc2+ZgPE0nCva6P/c3p1ItzTn86UHz++O6zpaG9LVXt8mmoDxDRIKrLHzJtGIBs 0wPeD+ZF8as38qbUrk7LmD3VVX9CV7sxfjGK/F2tNlmWmuKPUG3RkFuJqU7eiHBA 5lZNCsuvjBUn11yf6FrFnZAlEs578678kCgtfuj/l9wEZBoCwR8QFZvik/SYePPW yrA16Lz1OEHAawIf9BGQHku348pGu/Z44UjmISssTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdejtddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehleefudekudduveekieelgfeiffdvkefhkeeljeeujeegueekveffkeejjeev heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 May 2024 09:54:56 -0400 (EDT) Content-Language: en-US In-Reply-To: <87wmnidv3u.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285873 Archived-At: This is a multi-part message in MIME format. --------------fQ3ZOMRaB9VG8EfAneYa0De6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michael, On 25/05/2024 13:49, Michael Albinus wrote: >> The answer is that async-shell-command uses shell-mode as the major >> mode for the output buffer. For syntax highlighting, I guess. >> >> You make a good point that the shell history for such buffers would >> usually make no sense - even if the running process takes user input >> (usually not, but sometimes it might) - its input history would be >> different from the shell. >> >> So maybe we could just move the last form in shell-mode (which >> initializes comint-input-ring) to 'shell' > Don't know. (shell-mode) is called in shell-command since bcad49851742 > (1995-07-17). And it is called in tramp-handle-shell-command since > f5e29b9b70a5 (2011-09-04). > > (comint-read-input-ring) is called in shell-mode since > (1993-10-22). There might be packages which trust on the > comint-input-ring existence for buffers in shell mode, even if such > buffers are created by shell-command.. Yes, it would be an incompatibility - so we'll need to consider the migration path. See the attached patch - I suggest that any callers of 'shell-mode' that need the exact same input-ring setup also call shell-setup-input-ring (if it's fboundp - a version check). Or I suppose we could check the value of shell-setup-input-ring and skip history loading when it is empty. It's a more subtle incompatibility which might affect (or not) third-party code in similar ways. Either of the attached patches solves this part of the problem for me, please take your pick. --------------fQ3ZOMRaB9VG8EfAneYa0De6 Content-Type: text/x-patch; charset=UTF-8; name="shell-setup-input-ring.diff" Content-Disposition: attachment; filename="shell-setup-input-ring.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avc2hlbGwuZWwgYi9saXNwL3NoZWxsLmVsCmluZGV4IGU2YjMx NWVlNWMwLi5kNDg1YzhhZjU2NyAxMDA2NDQKLS0tIGEvbGlzcC9zaGVsbC5lbAorKysgYi9s aXNwL3NoZWxsLmVsCkBAIC03MTgsNyArNzE4LDEwIEBAIHNoZWxsLW1vZGUKIAogICA7OyBU aGlzIGlzIG5vdCByZWFsbHkgY29ycmVjdCwgc2luY2UgdGhlIHNoZWxsIGJ1ZmZlciBkb2Vz IG5vdCByZWFsbHkKICAgOzsgZWRpdCB0aGlzIGRpcmVjdG9yeS4gIEJ1dCBpdCBpcyB1c2Vm dWwgaW4gdGhlIGJ1ZmZlciBsaXN0IGFuZCBtZW51cy4KLSAgKHNldHEgbGlzdC1idWZmZXJz LWRpcmVjdG9yeSAoZXhwYW5kLWZpbGUtbmFtZSBkZWZhdWx0LWRpcmVjdG9yeSkpCisgIChz ZXRxIGxpc3QtYnVmZmVycy1kaXJlY3RvcnkgKGV4cGFuZC1maWxlLW5hbWUgZGVmYXVsdC1k aXJlY3RvcnkpKSkKKworKGRlZnVuIHNoZWxsLXNldHVwLWlucHV0LXJpbmcgKCkKKyAgIlNl dCB1cCBgY29taW50LWlucHV0LXJpbmcnIGZvciB0aGlzIGJ1ZmZlciwgZm9yIHRoZSBjaG9z ZW4gc2hlbGwuIgogICA7OyBzaGVsbC1kZXBlbmRlbnQgYXNzaWdubWVudHMuCiAgICh3aGVu IChyaW5nLWVtcHR5LXAgY29taW50LWlucHV0LXJpbmcpCiAgICAgKGxldCAoKHJlbW90ZSAo ZmlsZS1yZW1vdGUtcCBkZWZhdWx0LWRpcmVjdG9yeSkpCkBAIC05NDgsNiArOTUxLDcgQEAg c2hlbGwKICAgICAgICAgICAgICAgICAgIChzeW1ib2wtdmFsdWUgeGFyZ3MtbmFtZSkKICAg ICAgICAgICAgICAgICAnKCItaSIpKSkKICAgICAgICAoc2hlbGwtbW9kZSkKKyAgICAgICAo c2hlbGwtc2V0dXAtaW5wdXQtcmluZykKICAgICAgICAod2hlbiAoZmlsZS1leGlzdHMtcCBz dGFydGZpbGUpCiAgICAgICAgICA7OyBXYWl0IHVudGlsIHRoZSBwcm9tcHQgaGFzIGFwcGVh cmVkLgogICAgICAgICAgKHdoaWxlICg9IHN0YXJ0LXBvaW50IChwb2ludCkpCg== --------------fQ3ZOMRaB9VG8EfAneYa0De6 Content-Type: text/x-patch; charset=UTF-8; name="shell-no-start-prog.diff" Content-Disposition: attachment; filename="shell-no-start-prog.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avc2hlbGwuZWwgYi9saXNwL3NoZWxsLmVsCmluZGV4IGU2YjMx NWVlNWMwLi5jYTAyZDYwMjk2NiAxMDA2NDQKLS0tIGEvbGlzcC9zaGVsbC5lbAorKysgYi9s aXNwL3NoZWxsLmVsCkBAIC03MjAsOSArNzIwLDEwIEBAIHNoZWxsLW1vZGUKICAgOzsgZWRp dCB0aGlzIGRpcmVjdG9yeS4gIEJ1dCBpdCBpcyB1c2VmdWwgaW4gdGhlIGJ1ZmZlciBsaXN0 IGFuZCBtZW51cy4KICAgKHNldHEgbGlzdC1idWZmZXJzLWRpcmVjdG9yeSAoZXhwYW5kLWZp bGUtbmFtZSBkZWZhdWx0LWRpcmVjdG9yeSkpCiAgIDs7IHNoZWxsLWRlcGVuZGVudCBhc3Np Z25tZW50cy4KLSAgKHdoZW4gKHJpbmctZW1wdHktcCBjb21pbnQtaW5wdXQtcmluZykKKyAg KHdoZW4gKGFuZCAocmluZy1lbXB0eS1wIGNvbWludC1pbnB1dC1yaW5nKQorICAgICAgICAg ICAgIHNoZWxsLS1zdGFydC1wcm9nKQogICAgIChsZXQgKChyZW1vdGUgKGZpbGUtcmVtb3Rl LXAgZGVmYXVsdC1kaXJlY3RvcnkpKQotICAgICAgICAgIChzaGVsbCAob3Igc2hlbGwtLXN0 YXJ0LXByb2cgIiIpKQorICAgICAgICAgIChzaGVsbCBzaGVsbC0tc3RhcnQtcHJvZykKICAg ICAgICAgICAoaHNpemUgKGdldGVudiAiSElTVFNJWkUiKSkKICAgICAgICAgICAoaGZpbGUg KGdldGVudiAiSElTVEZJTEUiKSkpCiAgICAgICAod2hlbiByZW1vdGUK --------------fQ3ZOMRaB9VG8EfAneYa0De6--