* bug#3434: 23.0.91; Cursor face not changing
@ 2009-08-16 4:33 Luke Renn
0 siblings, 0 replies; 2+ messages in thread
From: Luke Renn @ 2009-08-16 4:33 UTC (permalink / raw)
To: 3434; +Cc: adrian.b.robert
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
> I looked at the code and cannot see how this could be happening. The
> region face is set to ns_selection_color in ns-win.el, but this
> should be overridden by .emacs read later.
It probably should, but it doesn't seem to.
This bug is easily fixed by changing the following line in ns-win.el:
(set-face-background 'region "ns_selection_color")
To:
(if (not (face-attribute 'region :background))
(set-face-background 'region "ns_selection_color"))
Tested and confirmed on a git checkout from 8/14.
The real fix may be to change when ns-win.el runs, but I didn't look into that.
Thanks,
Luke
[-- Attachment #2: Type: text/html, Size: 765 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#2870: 23.0.91; Cursor face not changing
@ 2009-04-02 22:33 Chong Yidong
2009-05-31 15:27 ` bug#3434: " Adrian Robert
0 siblings, 1 reply; 2+ messages in thread
From: Chong Yidong @ 2009-04-02 22:33 UTC (permalink / raw)
To: Adrian Robert; +Cc: emacs-pretest-bug, Alberto Simões
> Although I am able to configure the cursor face using the usual
> custumization tool, the real colors/face doesn't change.
>
> While the customization tool added to my .emacs the line:
> '(cursor ((t (:background "wheat" :foreground "black"))))
>
> under the faces configuration command, when emacs starts I get back
> the original cursor colors (that are just annoying because I can't see
> the character behind the cursor).
>
> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
> MacOS/NS.
I can't reproduce this, so it's likely a bug on NS. Adrian, can you
reproduce it?
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#3434: 23.0.91; Cursor face not changing
2009-04-02 22:33 bug#2870: " Chong Yidong
@ 2009-05-31 15:27 ` Adrian Robert
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Robert @ 2009-05-31 15:27 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-pretest-bug, Alberto Simões, Nikolaj Schumacher
On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:
>> Although I am able to configure the cursor face using the usual
>> custumization tool, the real colors/face doesn't change.
>>
>> While the customization tool added to my .emacs the line:
>> '(cursor ((t (:background "wheat" :foreground "black"))))
>>
>> under the faces configuration command, when emacs starts I get back
>> the original cursor colors (that are just annoying because I can't
>> see
>> the character behind the cursor).
>>
>> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
>> MacOS/NS.
>
> I can't reproduce this, so it's likely a bug on NS. Adrian, can you
> reproduce it?
I cannot.
Nikolaj Schumacher added later that:
> The same seems to happen for the region face. The background color
> reverts to ns_selection_color sometime after the custom variables are
> read. (It works when reading the custom settings again, later.)
I looked at the code and cannot see how this could be happening. The
region face is set to ns_selection_color in ns-win.el, but this
should be overridden by .emacs read later. This should have been
cleared up by David Reitter's changes around 2009-03-14, though since
the ChangeLog entries are incomplete it is difficult to be certain
when the last broken code was removed.
Anyway, if you still observe these in a recent build let me know and
I'll go on a more thorough witch-hunt.
thanks,
Adrian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-16 4:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-16 4:33 bug#3434: 23.0.91; Cursor face not changing Luke Renn
-- strict thread matches above, loose matches on Subject: below --
2009-04-02 22:33 bug#2870: " Chong Yidong
2009-05-31 15:27 ` bug#3434: " Adrian Robert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.