all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Luke Renn <luke.renn@gmail.com>
To: 3434@emacsbugs.donarmstrong.com
Cc: adrian.b.robert@gmail.com
Subject: bug#3434: 23.0.91; Cursor face not changing
Date: Sun, 16 Aug 2009 00:33:38 -0400	[thread overview]
Message-ID: <25cce60f0908152133u67ac8a33u1ab832e519fad008@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

> I looked at the code and cannot see how this could be happening.  The
> region face is set to ns_selection_color in ns-win.el, but this
> should be overridden by .emacs read later.

It probably should, but it doesn't seem to.

This bug is easily fixed by changing the following line in ns-win.el:

(set-face-background 'region "ns_selection_color")

To:

(if (not (face-attribute 'region :background))
    (set-face-background 'region "ns_selection_color"))

Tested and confirmed on a git checkout from 8/14.

The real fix may be to change when ns-win.el runs, but I didn't look into that.

Thanks,

Luke

[-- Attachment #2: Type: text/html, Size: 765 bytes --]

             reply	other threads:[~2009-08-16  4:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16  4:33 Luke Renn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-04-02 22:33 bug#2870: 23.0.91; Cursor face not changing Chong Yidong
2009-05-31 15:27 ` bug#3434: " Adrian Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25cce60f0908152133u67ac8a33u1ab832e519fad008@mail.gmail.com \
    --to=luke.renn@gmail.com \
    --cc=3434@emacsbugs.donarmstrong.com \
    --cc=adrian.b.robert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.